Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(virtual-core): optimization memo function inner logic #978

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

taylous
Copy link
Contributor

@taylous taylous commented Apr 6, 2025

summary

  1. the condition opts.key && opts.debug?.() was repeated multiple times, so I assigned it to a variable for reuse.
  2. for the const depsChanged = ... expression, i extracted it into a separate function instead of assigning it to a variable, to improve readability.
  3. i also replaced the pad function with String(...).padStart(...) to prevent unnecessary creation and enhance clarity.

if this PR gets approved, it might be better to move isDepsChanged to a different file instead of utils.ts, since all functions in utils.ts are meant to be exported and publicly usable.

Copy link

changeset-bot bot commented Apr 6, 2025

⚠️ No Changeset found

Latest commit: abcda37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Apr 6, 2025

View your CI Pipeline Execution ↗ for commit abcda37.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 29s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-06 16:06:51 UTC

Copy link

pkg-pr-new bot commented Apr 6, 2025

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@978

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@978

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@978

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@978

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@978

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@978

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@978

commit: abcda37

@taylous taylous changed the title feat(virtual-core): feat(virtual-core): optimization memo function inner logic Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant