fix(react-virtual): handle scrollElement cleanup after HMR
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hophiphip
changed the title
scrollElement cleanup on HMRscrollElement cleanup after HMR
hophiphip
changed the title
scrollElement cleanup after HMRscrollElement cleanup after HMR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HMR is triggered
useEffectcleanup function will call function returned frominstance._didMount().This will set
scrollElementto null andVirtualizerwill stop working.I added an additional check if
scrollElementis null and if it is - callinstance._willUpdate().This PR resolves #750.