fix(components/Doc): add spacing below the docs prev/next bar - #1106
Merged
Conversation
sukvvon
marked this pull request as draft
August 4, 2026 01:51
📝 WalkthroughWalkthroughChangesDocumentation navigation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sukvvon
force-pushed
the
fix/docnav-footer-gap
branch
from
August 4, 2026 01:55
9a78568 to
7da526f
Compare
sukvvon
force-pushed
the
fix/docnav-footer-gap
branch
from
August 4, 2026 01:58
7da526f to
f90b178
Compare
sukvvon
marked this pull request as ready for review
August 4, 2026 02:03
KevinVandy
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolled to the bottom of a docs page, the Previous/Next cards sit flush against the footer's top edge with no gap at all.
The bar is
sticky bottom-2. That offset spaces it from the viewport while it floats, but once the page bottoms out the bar settles as the last element of its flex column and there is nothing below it — the footer starts immediately.Fix
One spacer div after the bar in
Doc.tsx:This follows the spacing idiom already used in
MarkdownContent, which separates its sections with explicit spacer divs (h-12under the prose,py-4around the Edit on GitHub row) rather than padding on the elements themselves.Why not
pb-4on the bar itselfThat was my first attempt, and it was wrong: padding lives inside the sticky element's box, so it changes both states — the floating card would have moved from 8px to 24px off the viewport edge.
bottom-2deliberately sets the floating gap, and that part was never the bug.The two gaps measure different things and should stay different. Floating, the card is an overlay hovering above the text scrolling under it — tight to the edge is correct. Settled, it only needs enough room not to collide with the footer's top border; the section separation itself is already provided by the footer, which carries
py-12 lg:py-16of its own. That is also whyh-4and not something larger — 48px here would stack on top of the footer's own 48–64px.Measured on a docs page
Screenshot
AS-IS
TO-BE
Summary by CodeRabbit