test(query-core): fix mutationFn to use Promise.resolve to match TypeScript requirements #8875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Script requirements
|
View your CI Pipeline Execution ↗ for commit a6c81fe.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8875 +/- ##
===========================================
+ Coverage 46.59% 63.40% +16.80%
===========================================
Files 200 136 -64
Lines 7574 4861 -2713
Branches 1742 1374 -368
===========================================
- Hits 3529 3082 -447
+ Misses 3669 1538 -2131
+ Partials 376 241 -135 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this ESLint warning in the query-core hydration test.
"Async method 'mutationFn' has no 'await' expression.eslint@typescript-eslint/require-await"
The problem was in the mutation scope test where we had an async function without any await expressions. Instead of adding a pointless await, I simply removed the async keyword and made it return
Promise.resolve()directly. This keeps the code clean while still satisfying both TypeScript's MutationFunction type and the ESLint rule.