Skip to content

perf(vue-query): use shallowRef instead of ref #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 12, 2024
Merged

perf(vue-query): use shallowRef instead of ref #6657

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16de4ac
perf: use shallowRef
TheAlexLichter Jan 6, 2024
d259bfa
Merge branch 'main' into perf/use-shallow-ref
TheAlexLichter Jan 7, 2024
aa1b00b
Merge branch 'main' into perf/use-shallow-ref
TheAlexLichter Jan 8, 2024
031ce52
chore: lint
TheAlexLichter Jan 8, 2024
e78bab7
Merge branch 'main' into perf/use-shallow-ref
DamianOsipiuk Jan 12, 2024
9d4862e
chore: format with prettier
DamianOsipiuk Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/vue-query/src/useQueries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import {
getCurrentScope,
onScopeDispose,
readonly,
ref,
shallowRef,
watch,
} from 'vue-demi'

import { useQueryClient } from './useQueryClient'
import { cloneDeepUnref } from './utils'
import type { Ref } from 'vue-demi'
import type { ShallowRef } from 'vue-demi'
import type {
DefaultError,
DefinedQueryObserverResult,
Expand Down Expand Up @@ -259,7 +259,7 @@ export function useQueries<
combine?: (result: UseQueriesResults<T>) => TCombinedResult
},
queryClient?: QueryClient,
): Readonly<Ref<TCombinedResult>> {
): Readonly<ShallowRef<TCombinedResult>> {
if (process.env.NODE_ENV === 'development') {
if (!getCurrentScope()) {
console.warn(
Expand Down Expand Up @@ -294,7 +294,7 @@ export function useQueries<
defaultedQueries.value,
(options as QueriesObserverOptions<TCombinedResult>).combine,
)
const state = ref(getCombinedResult()) as Ref<TCombinedResult>
const state = shallowRef(getCombinedResult())

let unsubscribe = () => {
// noop
Expand Down Expand Up @@ -343,5 +343,5 @@ export function useQueries<
unsubscribe()
})

return readonly(state) as Readonly<Ref<TCombinedResult>>
return readonly(state) as Readonly<ShallowRef<TCombinedResult>>
}