Skip to content

Conversation

@LeCarbonator
Copy link
Contributor

🎯 Changes

The PR addresses two memory leaks related to the EventClient:

  • Unsubscribe from event listeners on cleanup
  • Fix queuedEvents from piling up FormApi references

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 9f6655e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 20, 2025

View your CI Pipeline Execution ↗ for commit 9f6655e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 22s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-20 08:52:08 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1866

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1866

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1866

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1866

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1866

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1866

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1866

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1866

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1866

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1866

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1866

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1866

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1866

commit: 9f6655e

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (6892ed0) to head (9f6655e).
⚠️ Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
packages/form-core/src/FormApi.ts 31.81% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   90.35%   89.80%   -0.56%     
==========================================
  Files          38       41       +3     
  Lines        1752     1853     +101     
  Branches      444      469      +25     
==========================================
+ Hits         1583     1664      +81     
- Misses        149      169      +20     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants