fix(form-core): make fieldMeta values optional to reflect runtime behaviour. #1787
+342
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avior fieldMeta is typed as Record<DeepKeys<TData>, AnyFieldMeta> but is initialized as an empty object. This causes TypeScript to incorrectly assume that accessing any valid field key will return a defined AnyFieldMeta object, leading to runtime crashes when accessing field metadata during the first render. Updated the fieldMeta type to include undefined to accurately reflect that field metadata is only available after a field has been mounted. BREAKING CHANGE: fieldMeta values are now typed as potentially undefined. Code that accesses fieldMeta without null checks will now show TypeScript errors. Use optional chaining or explicit undefined checks. Fixes TanStack#1774
🦋 Changeset detectedLatest commit: df8f012 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit df8f012
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1774
This PR addresses a type safety issue where
fieldMetais typed asRecord<DeepKeys<TData>, AnyFieldMeta>but is initialized as an empty object, causing runtime crashes when accessing field metadata during the first render.Changes
FormStateinterface to includeundefinedin fieldMeta typeType of Change
Breaking Changes
This is a breaking change for TypeScript users. Code that previously accessed fieldMeta without null checks will now show type errors, preventing runtime crashes.
Migration Example: