Skip to content

fix(core, react): export of formOptions results in build error#1351

Merged
harry-whorlow merged 1 commit intoTanStack:mainfrom
harry-whorlow:fix-form-build-error
Mar 28, 2025
Merged

fix(core, react): export of formOptions results in build error#1351
harry-whorlow merged 1 commit intoTanStack:mainfrom
harry-whorlow:fix-form-build-error

Conversation

@harry-whorlow
Copy link
Copy Markdown
Contributor

Exporting formOptions from start results in build error this PR reverts those changes and updated to docs to reflect this.

  • revert export of form core
  • updated SSR docs
  • updated tanstack start example

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 28, 2025

View your CI Pipeline Execution ↗ for commit 9c19fd8.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 40s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-28 17:36:34 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 28, 2025

@harry-whorlow harry-whorlow marked this pull request as ready for review March 28, 2025 17:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (38f4102) to head (9c19fd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1351       +/-   ##
===========================================
- Coverage   88.86%   45.51%   -43.35%     
===========================================
  Files          28       13       -15     
  Lines        1275      145     -1130     
  Branches      332       25      -307     
===========================================
- Hits         1133       66     -1067     
+ Misses        127       69       -58     
+ Partials       15       10        -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow harry-whorlow changed the title fix(core, react): export of formOptions breaks build error fix(core, react): export of formOptions results in build error Mar 28, 2025
@harry-whorlow harry-whorlow merged commit 4016a2b into TanStack:main Mar 28, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants