feat(queue): implement real email transport in the email processor#587
Open
Wittig18 wants to merge 1 commit into
Open
feat(queue): implement real email transport in the email processor#587Wittig18 wants to merge 1 commit into
Wittig18 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@Wittig18 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@mikewheeleer please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulateEmailSendtimeout in the email queue processor with a pluggableEmailTransportselected from validated env config (EMAIL_PROVIDER, SMTP/SES/SendGrid settings).{ success: true }with no delivery.Changes
src/queue/processors/email.transport.ts—EmailTransportinterface,ConsoleEmailTransport,SendGridEmailTransport(SendGrid v3 REST via axios),SmtpEmailTransport,SesEmailTransport(AWS SigV4),setEmailTransportOverride()for tests.src/queue/processors/email-processor.ts— Validates payload, dispatches viaresolveEmailTransport(), preserves{ success, message, data: { emailId } }return shape.src/config/env.schema.ts— Email transport env vars with Zod validation.src/queue/processors/email-processor.test.ts— Mock transport delivery, provider failure propagation, header-injection rejection.docs/email-notifications.md— Queue processor transport selection and config.Config
EMAIL_PROVIDERconsole(default),smtp,ses,sendgridEMAIL_SEND_TIMEOUT_MS10000)SMTP_*AWS_*SENDGRID_API_KEYTest plan
npm run lintnpm test -- src/queue/processors/email-processor.test.tsemail-notificationjob withEMAIL_PROVIDER=consoleand confirm success