test(notifications): harden and cover the email validator#576
Merged
Conversation
Contributor
|
love this — in it goes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #570.
Tightens
isValidEmailinsrc/services/notification.service.tsto reject control characters, comma/semicolon multi-recipient strings, quoting/backslash and angle-bracket forms, and addresses without a single@and a dotted domain with a TLD, while still accepting normal RFC-shaped addresses. Keeps the CR/LF rejection, boolean contract and method signature, and applies the check before any dispatch. Adds tests innotification.email-validation.test.tsand validation rules indocs/email-notifications.md.