Skip to content

Conversation

@ozhelezniak-talend
Copy link
Contributor

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks Schema interface methods with @JsonbTransient annotation to exclude them from JSON serialization and updates one method implementation to return an empty list instead of throwing an exception.

  • Added @JsonbTransient annotations to getEntryMap() and getEntriesOrdered() methods in the Schema interface
  • Changed getEntriesOrdered() implementation in Schemas.java to return emptyList() instead of throwing UnsupportedOperationException
  • Added @JsonbTransient annotation to getEntriesOrdered(Comparator<Entry>) method in Schemas.java

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
component-api/src/main/java/org/talend/sdk/component/api/record/Schema.java Added JsonbTransient annotations to prevent serialization of utility methods
component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/record/Schemas.java Added JsonbTransient annotation and changed exception to return empty list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonar-eks
Copy link

sonar-eks bot commented Oct 29, 2025

Passed Quality Gate passed

Issues

Measures

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants