feat(api): fetch full JDs at discovery through SSRF-hardened fetcher + extend local prerank (#263) - #317
Merged
Merged
Conversation
…her + extend local prerank (#263)
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42c6c85b7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 2 commits
August 30, 2026 12:29
… time budget and validate extracted text relevance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #263 (Epic #245 — Feed Engine).
Summary of Changes
SSRF-Hardened JD Upgrade (
apps/api/src/lib/jd-upgrade.ts):upgradeToFullJd(job, deps)fetches job pages through the existing SSRF-hardenedfetchJobPage(DNS pinning, 8s timeout, 2MB limit, max 3 redirects).descriptionText; preserves title, company, URL, and all other metadata.Discovery Pipeline Integration (
apps/api/src/lib/discovery.ts&apps/api/src/routes/discovery.ts):upgradeJd?: typeof upgradeToFullJdintoDiscoveryDeps.JD_FETCH_CAP = Number(process.env.DISCOVERY_JD_FETCH_CAP ?? 25).createJobso that salary parsing, seniority inference, content hashing, and local prerank operate on the full text.upgradeJd: upgradeToFullJdintoroutes/discovery.tsdefault dependencies.Keyword Catalog Widening (
apps/api/src/lib/analysis-core.ts):keywordCatalogfrom 20 to 75 unique technologies (Docker, Kubernetes, Terraform, AWS, Azure, GCP, GraphQL, Kafka, etc.).MIN_EVIDENCE_SKILLS = 3and the null-score contract inlocal-fit.ts.Testing & Verification:
jd-upgrade.test.ts(short JD upgrade, skipping >=600 chars, skipping missing URL, failing closed on blocked fetch, refusing < 1.5x expansion).discovery.test.ts(fetch cap bounding at 25, prerank scoring on upgraded text).local-fit.test.ts(full JD clearing evidence floor) and catalog uniqueness test inanalysis-core.test.ts.npm run check(monorepo lint + typecheck + Next.js build + API build) clean.