feat(api): Greenhouse, Lever, and Ashby public-board adapters wired into discovery (#261) - #313
Merged
Merged
Conversation
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 183cd410c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…reserve HTML block boundaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #261 (Epic #245 — Feed Engine).
Summary of Changes
Board Fetchers & Normalizers (
apps/api/src/lib/job-sources/boards.ts):htmlToText(html): Two-pass HTML entity decoding and tag stripping vianode-html-parser, correctly handling double-encoded HTML from Greenhouse (<p>).SourcedJobrecords with full JD descriptions, inferred workplace types, and parsed salaries (viaparseSalaryFromText).fetchBoardJobs(target): Strict token validation using/^[A-Za-z0-9._-]+$/before reaching external URLs; dispatches to fixed HTTPS host endpoints with 15s timeout andUser-Agent: JobOpsCopilot/1.0 (+board-watch).fetchTargetCompanyBoards(targets): Iterates enabled target companies; per-target failures log a warning and continue without failing the overall sweep.Source Normalization (
apps/api/src/lib/job-sources/normalize.ts):clean,employmentLabel, andinferWorkplaceTypefor reuse across external board adapters.Discovery Integration (
apps/api/src/lib/discovery.ts&apps/api/src/routes/discovery.ts):listTargetCompaniesandfetchBoardstoDiscoveryDeps.insertIfNew) that encapsulates deduplication againstseenkeys,deps.createJob, best-effortprerankAnalysis, and concurrent Postgres 23505 race handling.insertIfNew.DiscoveryResult.sourceto reflect contributing board types (e.g.adzuna+greenhouse).listTargetCompaniesfrom@/data/target-company-storeandfetchBoards: fetchTargetCompanyBoardsinto route defaults.Testing & Verification:
apps/api/src/lib/job-sources/boards.test.ts(6 tests covering entity decoding, normalizer field mappings, salary extraction, invalid token rejection, and fault tolerance).apps/api/src/lib/discovery.test.ts(11 tests verifying cross-deduplication between board jobs and search results, composite source reporting, and disabled target skips).npm run check(typecheck + ESLint + Next.js build + API build) clean with 0 errors.