Skip to content

test: move the materialized view Quick Switcher tests onto the frecency key API #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Sep 23, 2026
+14 −4
Merged

test: move the materialized view Quick Switcher tests onto the frecency key API #3100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion TableProTests/Views/Main/MaterializedViewRowWriteTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ struct MaterializedViewRowWriteTests {
let item = try #require(
QuickSwitcherViewModel.makeCrossConnectionItems(
tables: [TableInfo(name: "daily_totals", type: .materializedView, rowCount: nil)],
target: target
target: target,
connectionSwitchesDatabases: true
).first
)
fromSwitcher.handleQuickSwitcherSelection(item)
Expand Down
15 changes: 12 additions & 3 deletions TableProTests/Views/QuickSwitcherObjectKindTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ struct QuickSwitcherObjectKindTests {
TableInfo(name: "daily_totals", type: .materializedView, rowCount: nil),
TableInfo(name: "orders", type: .partitionedTable, rowCount: nil)
],
target: target
target: target,
connectionSwitchesDatabases: true
)

#expect(items.map(\.tableType) == [.materializedView, .partitionedTable])
Expand All @@ -46,7 +47,11 @@ struct QuickSwitcherObjectKindTests {
defer { coordinator.teardown() }

let item = QuickSwitcherItem(
id: QuickSwitcherItem.tableItemId(name: "daily_totals", schema: "public"),
frecencyKey: QuickSwitcherFrecencyKey.table(
name: "daily_totals",
schema: "public",
in: .init(database: "shop", connectionSwitchesDatabases: true)
),
name: "daily_totals",
kind: .view,
subtitle: String(localized: "Materialized View"),
Expand Down Expand Up @@ -75,7 +80,11 @@ struct QuickSwitcherObjectKindTests {
defer { coordinator.teardown() }

let item = QuickSwitcherItem(
id: QuickSwitcherItem.tableItemId(name: "events", schema: "public"),
frecencyKey: QuickSwitcherFrecencyKey.table(
name: "events",
schema: "public",
in: .init(database: "shop", connectionSwitchesDatabases: true)
),
name: "events",
kind: .table,
subtitle: String(localized: "Partitioned Table"),
Expand Down
Loading