Skip to content

Build cleanup#131

Draft
mwaxmonsky wants to merge 29 commits into
TURBO-ESM:mainfrom
mwaxmonsky:build_cleanup
Draft

Build cleanup#131
mwaxmonsky wants to merge 29 commits into
TURBO-ESM:mainfrom
mwaxmonsky:build_cleanup

Conversation

@mwaxmonsky
Copy link
Copy Markdown
Collaborator

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code maintenance (refactoring, optimization, etc.)
  • CI/CD changes

Related Issues

Fixes #

Changes Made

  • Makes templates consistently set integer and real flags.
  • Updates build infrastructure to accept int flags as well as real flags.

Testing

Test Environment

  • Tested on derecho
  • Tested locally
  • Other: _______________

Compiler(s) Tested

  • Intel
  • GNU
  • NVHPC
  • Other: _______________

Test Cases

  • All existing tests pass
  • New tests added and pass
  • Manual testing performed
  • Examples run successfully

Test Results

Performance Impact

  • No performance impact expected
  • Performance improvement
  • Potential performance impact (explain below)

Documentation

  • Code comments updated
  • README updated
  • User documentation updated
  • Developer documentation updated
  • No documentation changes needed

Checklist

  • My code follows the project's coding standards
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

@mwaxmonsky
Copy link
Copy Markdown
Collaborator Author

Just did a quick test and llvm-flang does work (to some degree) where we can probably get the workflow to pass but it requires merging #51 as it needs the updated containers (looks like the path issues with netCDF were resolved in that particular container in the newer images).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant