[SCAFFOLD] AMReX shim layer for {zonal,meridional}_edge_thickness#28
Open
johnmauff wants to merge 24 commits into
Open
[SCAFFOLD] AMReX shim layer for {zonal,meridional}_edge_thickness#28johnmauff wants to merge 24 commits into
johnmauff wants to merge 24 commits into
Conversation
…KNESS_MODE)
Rename original implementation to zonal_edge_thickness_fortran, adapting it
to take RealArray_t containers and explicit scalar args (h_min, upwind_1st,
monotonic, simple_2nd) in place of the G/GV/CS structs. Add new shim
zonal_edge_thickness with the same public signature: wraps raw arrays into
containers, dispatches via ZONAL_EDGE_THICKNESS_MODE={FORTRAN,CAPTURE,AMREX}.
Capture mode records inputs and outputs to capture/zonal_edge_thickness.{bin,meta}.
Add turbotmp_zonal_edge_thickness_bridge bind(C) interface for the C++/AMReX side.
No callers needed updating (5 call sites in MOM_continuity_PPM.F90 unchanged).
Co-authored-by: Claude <noreply@anthropic.com>
…idge skill Co-authored-by: Claude <noreply@anthropic.com>
alperaltuntas
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Fortran shim layer for the {zonal, meridional}_edge_thickness functions. Additionally, the function set_continuity_box was added, which provides a function that creates a box iterator for the entire continuity equation solver