Skip to content

refactor: 불필요한 변수 및 타입 체크 제거 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyH0ng merged 7 commits into from
Mar 2, 2026
Merged

refactor: 불필요한 변수 및 타입 체크 제거 #329

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73a5211
Apply suggested fix to src/components/common/FileDropzone.tsx from Co…
AndyH0ng Mar 2, 2026
5a97d31
Apply suggested fix to src/components/common/FileDropzone.tsx from Co…
AndyH0ng Mar 2, 2026
a954b8d
Apply suggested fix to src/components/common/FileDropzone.tsx from Co…
AndyH0ng Mar 2, 2026
45877ea
Apply suggested fix to src/components/common/FileDropzone.tsx from Co…
AndyH0ng Mar 2, 2026
f99b2c5
Apply suggested fix to src/components/common/FileDropzone.tsx from Co…
AndyH0ng Mar 2, 2026
d2d8fdf
fix: 빌드 오류 수정
AndyH0ng Mar 2, 2026
f0b8dec
fix: 제미나이 리뷰 반영
AndyH0ng Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/components/common/FileDropzone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ export default function FileDropzone({
const dragCounter = useRef(0);
const [isDragging, setIsDragging] = useState(false);
const isUploading = currentStep === 'uploading' || currentStep === 'finishing';
const isDisabled = disabled;
const isBlocked = isDisabled || isUploading; // 업로드 중에는 모든 입력 차단
const isBlocked = disabled || isUploading; // 업로드 중에는 모든 입력 차단

useEffect(() => {
if (error) showToast.warning('업로드에 실패했습니다.', error);
Expand All @@ -56,7 +55,6 @@ export default function FileDropzone({
const file = fileList.item(0);
if (!file) return;

if (typeof onFileSelected !== 'function') return;
onFileSelected(file);

if (inputRef.current) inputRef.current.value = ''; // 같은 파일 다시 선택 가능하게 (선택창 value 초기화)
Expand Down Expand Up @@ -101,15 +99,13 @@ export default function FileDropzone({
const file = e.dataTransfer.files?.item(0);
if (!file) return;

if (typeof onFileSelected !== 'function') return;
onFileSelected(file);
};

/** 업로드 취소 */
const handleCancelUploading = (e: React.MouseEvent<HTMLButtonElement>) => {
e.preventDefault();
e.stopPropagation();
if (typeof onCancelUpload !== 'function') return;
onCancelUpload();
};

Expand Down Expand Up @@ -147,7 +143,7 @@ export default function FileDropzone({
onDrop={handleDrop}
className={clsx(
'group relative w-full overflow-hidden rounded-2xl border bg-white px-8 py-14 shadow-sm transition focus:ring-1 focus:ring-gray-200',
isDisabled && !isUploading && 'cursor-not-allowed opacity-60',
disabled && !isUploading && 'cursor-not-allowed opacity-60',
isUploading && 'cursor-default',
!isBlocked && 'cursor-pointer hover:bg-gray-100',
showDragOverlay ? 'border-gray-900 ring-1 ring-gray-200' : 'border-gray-200',
Expand Down