Bleached tooltip indicator fix + ghostly ghostly support #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay color for tooltip preview
Contributor
Author
|
actually dont accept this yet it has issues |
Contributor
Author
|
waiting to get confirmation on if making a different |
Owner
|
this was on purpose btw 💔 |
Contributor
Author
|
what was? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
True bleached/undyed pieces (bleached before patch with
"color": "160:101:64") used to try to fallback to display color to determine hex. This meant that pieces of bleached fairy (or other armors that switch colors) would stop showing tooltip as "UNDYED" if they were worn (wearing them doesn't remove thecolor:tag, they become visibly bleached once strong updated).Ghostly also has some hexes like fairy where they would save before a certain update inside
color:and stay like that permanently.