Fix custom shortcuts in HedgeDoc editor not always working #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding the shortcuts to HedgeDoc's CodeMirror editor directly by setting
extraKeys, I disabled the filter on different input elements thathotkeys.jsuses by default. (See https://wangchujiang.com/hotkeys-js/#filter). This allows the shortcuts defined byhotkeys.jsto work in the editor as well.Setting
extraKeysalso overrides the default shortcuts that CodeMirror defines, such as f10 to make the editor take up the full window. Since this code does not override this anymore, these shortcuts should work again after this change.There should be no or little overlap with default CodeMirror hotkeys, but it is still a good idea to test if nothing breaks because of this change.
Closes #450