Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13263] Add null checks to methods in Student class #13264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#13263] Add null checks to methods in Student class #13264

wants to merge 1 commit into from

Conversation

DhiraPT
Copy link
Contributor

@DhiraPT DhiraPT commented Mar 10, 2025

Fixes #13263

Outline of Solution

Modified getTeamName(), getSectionName(), and getSection() to safely handle null values before accessing team properties.

@DhiraPT DhiraPT requested a review from jasonqiu212 March 10, 2025 20:39
@DhiraPT DhiraPT self-assigned this Mar 10, 2025
jasonqiu212
jasonqiu212 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the bug catch

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@xenosf xenosf Awaiting requested review from xenosf

@domoberzin domoberzin Awaiting requested review from domoberzin

Assignees

@DhiraPT DhiraPT

Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException in Student class methods when student team is null
2 participants
@DhiraPT @jasonqiu212