Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate tests for QueryLogsActionTest #13234

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[#12048] Migrate tests for QueryLogsActionTest #13234

wants to merge 7 commits into from

Conversation

InfinityTwo
Copy link
Contributor

Part of #12048

Outline of Solution
Added the unit tests for QueryLogsActionTest for PostgreSQL.

jasonqiu212
jasonqiu212 reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work migrating this monster unit test! Some minor comments below

jasonqiu212
jasonqiu212 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the changes

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@xenosf xenosf Awaiting requested review from xenosf

@domoberzin domoberzin Awaiting requested review from domoberzin

Assignees
No one assigned
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InfinityTwo @jasonqiu212