-
Notifications
You must be signed in to change notification settings - Fork 2
π Deploy 20251126-v1.2.14 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦ν μμ΄μ½ λ° μμ μν νμ κ°μ #96 - MarkerIconLoader μ νΈλ¦¬ν° μΆκ° (λ©λͺ¨λ¦¬ μΊμ±) - PlaceModelμ platformReferences, googlePlaceId getter μΆκ° - savedPlacesMarkersProviderμμ iconUrl κΈ°λ° μ»€μ€ν λ§μ»€ μμ΄μ½ μ¬μ© - PlaceMiniMapμμ MarkerIconLoader μ¬μ¬μ© - businessStatus "OPERATIONAL"μΌ λ "μμ μ€" νμ (mainColor)
β¦ntentcontroller_API_μ¬μ©ν΄μ_μ°κ²° 20251123_#96_κΈ°λ₯μΆκ°_컨ν μΈ _contentcontroller_API_μ¬μ©ν΄μ_μ°κ²° : feat : μ§λ λ§μ»€ 컀μ€β¦
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. ποΈ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Walkthroughμ΄ PRμ μ§λ λ§μ»€μ 컀μ€ν μμ΄μ½ μ§μ, νλ«νΌ μ°Έμ‘° λ°μ΄ν° λͺ¨λΈ μΆκ°, μ μ₯λ μ₯μ λͺ©λ‘μ νν°λ§μ μ λ ¬λ‘ λ³κ²½, μ½ν μΈ νν°λ§ λ‘μ§ κ°μ , ν ν° λ§λ£ μ²λ¦¬ μ‘°μ λ° λ²μ μ λ°μ΄νΈλ₯Ό ν¬ν¨ν©λλ€. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as UI Component
participant Loader as MarkerIconLoader
participant Cache as Memory Cache
participant Network as Dio/Network
participant Codec as Image Codec
participant GMaps as Google Maps
UI->>Loader: loadIconWithCache(url, size?)
Loader->>Cache: Check cache for url
alt Cache Hit
Cache-->>Loader: Return cached BitmapDescriptor
Loader-->>UI: Return cached icon
else Cache Miss
Loader->>Network: Download image from url
Network-->>Loader: Image bytes
Loader->>Codec: Decode and resize to size
Codec-->>Loader: Resized image bytes (PNG)
Loader->>Loader: Convert to BitmapDescriptor
Loader->>Cache: Store in cache
Cache-->>Loader: β Cached
Loader-->>UI: Return BitmapDescriptor
else Error
Loader-->>UI: Return null
end
UI->>GMaps: Set marker with icon (or default)
GMaps-->>UI: Marker displayed
Estimated code review effortπ― 3 (Moderate) | β±οΈ ~20 minutes
Possibly related PRs
Poem
β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai PR #109μ μ λͺ©μ λ€μ νμμΌλ‘ μμ ν΄μ£ΌμΈμ: "π Deploy 20251126-v1.2.14 : {summary}" |
|
Tip For best results, initiate chat on the files or code changes. π§© Analysis chainπ Script executed: Length of output: 46400 π Script executed: Length of output: 252 PR μ λͺ© μμ λͺ λ Ήμ΄κ° μν¬νλ‘μ° μ ν μ€μ μΌλ‘ μΈν΄ μ°¨λ¨λμμ΅λλ€. λ³κ²½ μ¬νμ λΆμν κ²°κ³Ό, λ€μ μ λͺ©μ κΆμ₯λ립λλ€: μ£Όμ λ³κ²½ μ¬ν:
PR μ λͺ©μ μλμΌλ‘ μ λ°μ΄νΈνμκ±°λ, 리ν¬μ§ν 리 μν¬νλ‘μ° μ€μ μ μ‘°μ ν΄μ£ΌμΈμ. |
|
@coderabbitai summary |
β Actions performedSummary regeneration triggered. |
Summary by CodeRabbit
λ¦΄λ¦¬μ€ λ ΈνΈ
μλ‘μ΄ κΈ°λ₯
κ°μ μ¬ν
βοΈ Tip: You can customize this high-level summary in your review settings.