-
Notifications
You must be signed in to change notification settings - Fork 1
[๐BUG] QA #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[๐BUG] QA #337
Conversation
main ์ต์ ํ
main ์ต์ ํ
โฆinto bug/qa-332
main ์ต์ ํ
|
Caution Review failedThe pull request is closed. Walkthroughํ ์คํธ ๋ชจ๋ฌ ๋๋น๊ฐ ์กฐ์ , /v1/job/todo ํธ์ถ์์ Authorization ํค๋ ์ ๊ฑฐ, useJobOtherQuery ์ธ์ยท์๋ํฌ์ธํธ๋ฅผ jobIdโtodoGroupId๋ก ๋ณ๊ฒฝ ๋ฐ ProfileCard/ํธ์ถ๋ถ ์ ๋ฐ์ดํธ, RecommendTodo์์ โMore todoโ ์ก์ ์ ๊ฑฐ๊ฐ ํฌํจ๋จ. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant PC as ProfileCard
participant Q as useJobOtherQuery(todoGroupId)
participant API as /v1/todo/other/simple/:todoGroupId
PC->>Q: ํธ์ถ(todoGroupId)
Q->>API: GET /v1/todo/other/simple/{todoGroupId}
API-->>Q: 200 OK (DreamerList)
Q-->>PC: ๋ฐ์ดํฐ ๋ฐํ
sequenceDiagram
autonumber
participant H as useJobTodoCategory
participant API as /v1/job/todo
H->>API: GET /v1/job/todo?id=&todoCategory= (ํค๋ ์์ด)
API-->>H: 200 OK (๋ฐ์ดํฐ)
Note over H: try/catch ์ ์ง, ๋ก๊น
/ํ์ฑ ๋์ผ
Estimated code review effort๐ฏ 3 (Moderate) | โฑ๏ธ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
๐ Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ๐ Files selected for processing (2)
โจ Finishing Touches
๐งช Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
๐งน Nitpick comments (3)
src/common/CheckList.tsx (1)
292-300: ToastModal ๋๋น ์ถ์ ๋ฐ์ OK. ๋ค๊ตญ์ด/์ค๋ฐ๊ฟ ์ ๋ ์ด์์ ๊นจ์ง๋ง ํ์ธ ๋ถํ๊ธด ํ ์คํธ(์: ๋ฒ์ญ)์์ ๋ฒํผ ์์ญ์ด ์ค๋ฐ๊ฟ์ผ๋ก ๋ฐ๋ฆฌ์ง ์๋์ง ํ๋ฒ ํ์ธํด ์ฃผ์ธ์. ํ์ ์ ๋ฐ์ํ ํด๋์ค๋ก ์์ ์ฅ์น ๊ถ์ฅ.
๊ฐ๋ฅํ ๋์:
- width="w-[350px]" + width="max-w-[350px] w-auto md:w-[350px]"src/hook/useJobQuery.ts (1)
170-177: ์ธ์ฆ ํค๋์ 'Bearer null' ์ ์ก ๊ฐ๋ฅ์ฑ ์ฐจ๋จ ๊ถ์ฅํ ํฐ์ด ์์ ๋๋ Authorization ํค๋๊ฐ ์ ์ก๋ ์ ์์ต๋๋ค. ์กฐ๊ฑด๋ถ ํค๋๋ก ๋ฐฉ์งํด ์ฃผ์ธ์. ๋ฐฑ์๋๊ฐ ๋น๋ก๊ทธ์ธ ์ ๊ทผ์ ํ์ฉํ๋์ง๋ ํ์ธ ๋ฐ๋๋๋ค.
- const token = localStorage.getItem('accessToken'); - const response = await api.get(`/v1/todo/other/simple/${todoGroupId}`, { - headers: { - Authorization: `Bearer ${token}`, - }, - }); + const token = localStorage.getItem('accessToken'); + const headers = token ? { Authorization: `Bearer ${token}` } : undefined; + const response = await api.get(`/v1/todo/other/simple/${todoGroupId}`, { + headers, + });src/pages/jobDetail/components/ProfileCard.tsx (1)
16-19: ์กฐํ ๊ธฐ์ค ์ ํ ํ์ธ ํ์: ๋งํฌ ์ด๋์ ์ฌ์ ํ jobId ์ฌ์ฉ๋ชฉ๋ก ๋ฐ์ดํฐ๋ todoGroupId๋ก ๊ฐ์ ธ์ค์ง๋ง ์๋จ "๋ ๋ณด๋ฌ๊ฐ๊ธฐ"๋
/others/${jobId}๋ก ์ด๋ํฉ๋๋ค. ์๋(์ง์ ๊ธฐ์ค ํ์ด์ง ์ด๋)๊ฐ ๋ง๋์ง ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค. ๋ง์ฝ ๊ทธ๋ฃน ๊ธฐ์ค ์ด๋์ด์ด์ผ ํ๋ฉด ๋ผ์ฐํ ํ๋ผ๋ฏธํฐ๋ ์ ํฉ์ฑ ๋ง์ถฐ์ฃผ์ธ์.
๐ Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
๐ Files selected for processing (6)
src/common/CheckList.tsx(1 hunks)src/hook/jobinfo/useJobTodoCategory.ts(0 hunks)src/hook/useJobQuery.ts(2 hunks)src/pages/jobDetail/components/ProfileCard.tsx(1 hunks)src/pages/jobDetail/components/RecommendTodo.tsx(0 hunks)src/pages/otherTodoList/OtherTodoListPage.tsx(1 hunks)
๐ค Files with no reviewable changes (2)
- src/pages/jobDetail/components/RecommendTodo.tsx
- src/hook/jobinfo/useJobTodoCategory.ts
๐ Additional comments (3)
src/hook/useJobQuery.ts (1)
185-189: todoGroupId ๊ธฐ๋ฐ์ผ๋ก์ ์ฟผ๋ฆฌ ์ ํ LGTM์ฟผ๋ฆฌ ํค์ ํ๋ผ๋ฏธํฐ ๋ชจ๋ ์ผ๊ด์ฑ ์๊ฒ ์ ๋ฐ์ดํธ๋์ด ์บ์ ์ถฉ๋ ์ฐ๋ ค ์์ต๋๋ค.
src/pages/otherTodoList/OtherTodoListPage.tsx (1)
111-116: ProfileCard์ todoGroupId ์ ๋ฌ ๋ณ๊ฒฝ LGTM๋ฐ์ดํฐ ๋ชจ๋ธ(eachTodos.todoGroupId)๊ณผ ์ปดํฌ๋ํธ prop์ด ์ผ์นํฉ๋๋ค.
src/pages/jobDetail/components/ProfileCard.tsx (1)
12-13: ์ prop(todoGroupId) ์ถ๊ฐ ๋ฐ์ LGTMํ์ดํ๊ณผ ์ฌ์ฉ์ฒ ์ผ๊ด์ฑ ๋ฌธ์ ์์ต๋๋ค.
๐ ํ ๋ฆฌํ์คํธ ์ ์
#332
๐ ์์ ๋ด์ฉ
QA ์์
๐ธ ์คํฌ๋ฆฐ์ท (์ ํ ์ฌํญ)
๐ ๊ธฐํ
Summary by CodeRabbit