Skip to content

Conversation

@Chasyuss
Copy link
Member

@Chasyuss Chasyuss commented Sep 7, 2025

๐Ÿš€ ํ’€ ๋ฆฌํ€˜์ŠคํŠธ ์ œ์•ˆ

  • ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๊ธฐ๋Šฅ ์‚ญ์ œ
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์Šคํƒ€์ผ๋ง
  • ์˜์กด์„ฑ, ํ™˜๊ฒฝ ๋ณ€์ˆ˜, ๋นŒ๋“œ ๊ด€๋ จ ์ฝ”๋“œ ์—…๋ฐ์ดํŠธ
  • ๊ธฐํƒ€

โœˆ๏ธ ๊ด€๋ จ ์ด์Šˆ

#332

๐Ÿ“‹ ์ž‘์—… ๋‚ด์šฉ

QA ์ˆ˜์ •

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ ์‚ฌํ•ญ)

๐Ÿ“„ ๊ธฐํƒ€

Summary by CodeRabbit

  • ์Šคํƒ€์ผ
    • ์‚ญ์ œ ํ† ์ŠคํŠธ ํญ์„ ์ถ•์†Œํ•ด ๊ฐ€๋…์„ฑ๊ณผ ์ผ๊ด€์„ฑ ๊ฐœ์„ .
    • ์ถ”์ฒœ ํ•  ์ผ ํ—ค๋”์—์„œ โ€˜๋” ๋ณด๊ธฐโ€™ ์•ก์…˜ ์ œ๊ฑฐ๋กœ ์ธํ„ฐํŽ˜์ด์Šค ๊ฐ„์†Œํ™”.
  • ๋ฒ„๊ทธ ์ˆ˜์ •
    • ํ”„๋กœํ•„ ์นด๋“œ๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ ํ•  ์ผ ๊ทธ๋ฃน(todoGroupId) ๊ธฐ์ค€์œผ๋กœ ๋‹ค๋ฅธ ์‚ฌ์šฉ์ž ๋ชฉ๋ก์„ ์กฐํšŒํ•˜๋„๋ก ์ˆ˜์ •.
  • ๋ฆฌํŒฉํ„ฐ
    • ์ผ๋ถ€ ๋ฐ์ดํ„ฐ ์กฐํšŒ์—์„œ ์ธ์ฆ ํ† ํฐ ์˜์กด์„ฑ์„ ์ œ๊ฑฐํ•ด ํ˜ธ์ถœ ๋ฐฉ์‹ ๊ฐ„์†Œํ™” ๋ฐ ์•ˆ์ •์„ฑ ํ–ฅ์ƒ.
    • ์ปค๋ฎค๋‹ˆํ‹ฐ ์‚ฌ์ด๋“œ๋ฐ”์—์„œ ์ƒ์œ„ 3๊ฐœ ํ•ญ๋ชฉ๋งŒ ํ‘œ์‹œํ•˜๋„๋ก ์ œํ•œ.
  • ํ’ˆ์งˆ ๊ฐœ์„ 
    • ๋ ˆ๋ฒจ ๋ฌธ์ž์—ด ์ฒ˜๋ฆฌ์— ์•ˆ์ „ํ•œ ์ ‘๊ทผ ๋ฐฉ์‹ ์ ์šฉ.

@Chasyuss Chasyuss requested a review from cywin1018 September 7, 2025 14:23
@coderabbitai
Copy link

coderabbitai bot commented Sep 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

ํ† ์ŠคํŠธ ๋ชจ๋‹ฌ ๋„ˆ๋น„๊ฐ’ ์กฐ์ •, /v1/job/todo ํ˜ธ์ถœ์—์„œ Authorization ํ—ค๋” ์ œ๊ฑฐ, useJobOtherQuery ์ธ์žยท์—”๋“œํฌ์ธํŠธ๋ฅผ jobIdโ†’todoGroupId๋กœ ๋ณ€๊ฒฝ ๋ฐ ProfileCard/ํ˜ธ์ถœ๋ถ€ ์—…๋ฐ์ดํŠธ, RecommendTodo์—์„œ โ€œMore todoโ€ ์•ก์…˜ ์ œ๊ฑฐ๊ฐ€ ํฌํ•จ๋จ.

Changes

Cohort / File(s) Summary
ToastModal ๋„ˆ๋น„ ์กฐ์ •
src/common/CheckList.tsx
์‚ญ์ œ ํ† ์ŠคํŠธ ๋ชจ๋‹ฌ์˜ width ํด๋ž˜์Šค๊ฐ€ w-[469px] โ†’ w-[350px]๋กœ ๋ณ€๊ฒฝ๋จ.
Job Todo ์นดํ…Œ๊ณ ๋ฆฌ ์กฐํšŒ ํ—ค๋” ์ •๋ฆฌ
src/hook/jobinfo/useJobTodoCategory.ts
localStorage์—์„œ ํ† ํฐ ์กฐํšŒ ๋ฐ Authorization ํ—ค๋” ์ œ๊ฑฐ. /v1/job/todo GET์„ ์ฟผ๋ฆฌํŒŒ๋ผ๋ฏธํ„ฐ๋งŒ์œผ๋กœ ํ˜ธ์ถœํ•˜๋„๋ก ๋‹จ์ˆœํ™”.
todoGroupId ์ „ํŒŒ ๋ฐ ์กฐํšŒ ์—”๋“œํฌ์ธํŠธ ๋ณ€๊ฒฝ
src/hook/useJobQuery.ts, src/pages/jobDetail/components/ProfileCard.tsx, src/pages/otherTodoList/OtherTodoListPage.tsx
useJobOtherQuery์˜ ์ธ์ž๊ฐ€ jobId โ†’ todoGroupId๋กœ ๋ณ€๊ฒฝ๋˜๊ณ , API๊ฐ€ /v1/todo/other/simple/${todoGroupId}๋กœ ์ˆ˜์ •๋จ. ProfileCard์— todoGroupId ํ•„์ˆ˜ prop ์ถ”๊ฐ€ ๋ฐ ํ˜ธ์ถœ๋ถ€ ์—…๋ฐ์ดํŠธ(OtherTodoListPage ํฌํ•จ).
RecommendTodo ํ—ค๋” UI ์ •๋ฆฌ
src/pages/jobDetail/components/RecommendTodo.tsx
์šฐ์ธก ์ •๋ ฌ๋œ โ€œMore todoโ€ ์•ก์…˜(ํ…์ŠคํŠธ+์•„์ด์ฝ˜) ์ œ๊ฑฐ. ์ปดํฌ๋„ŒํŠธ ์‹œ๊ทธ๋‹ˆ์ฒ˜ ๋ณ€ํ™” ์—†์Œ.
Community ๋ Œ๋”๋ง/์ •๊ทœํ™” ์†Œ์†Œ ๋ณ€๊ฒฝ
src/pages/community/components/CommunityContents.tsx, src/pages/community/components/CommunityLeftSide.tsx
normalizeLevel์— optional chaining ์ ์šฉ(s?.replace), ์ธ๊ธฐ ๋ฆฌ์ŠคํŠธ ๋ Œ๋”๋ง์„ popularTodos.slice(0, 3)๋กœ ์ œํ•œ.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant PC as ProfileCard
  participant Q as useJobOtherQuery(todoGroupId)
  participant API as /v1/todo/other/simple/:todoGroupId

  PC->>Q: ํ˜ธ์ถœ(todoGroupId)
  Q->>API: GET /v1/todo/other/simple/{todoGroupId}
  API-->>Q: 200 OK (DreamerList)
  Q-->>PC: ๋ฐ์ดํ„ฐ ๋ฐ˜ํ™˜
Loading
sequenceDiagram
  autonumber
  participant H as useJobTodoCategory
  participant API as /v1/job/todo

  H->>API: GET /v1/job/todo?id=&todoCategory= (ํ—ค๋” ์—†์ด)
  API-->>H: 200 OK (๋ฐ์ดํ„ฐ)
  Note over H: try/catch ์œ ์ง€, ๋กœ๊น…/ํŒŒ์‹ฑ ๋™์ผ
Loading

Estimated code review effort

๐ŸŽฏ 3 (Moderate) | โฑ๏ธ ~20 minutes

Possibly related PRs

Suggested labels

๐Ÿ›Bug

Suggested reviewers

  • cywin1018

Poem

๊นก์ด๊นก์ด, ๋ชจ๋‹ฌ ํญ์„ ์‚ด์ง ์ค„์˜€๋„ค ๐Ÿ‡
todo ๋ฌถ์Œ์—” ์ƒˆ ์ด๋ฆ„์„ ์‹ค์–ด ๋ณด๋ƒˆ๋„ค
ํ† ํฐ์€ ์ž ์‹œ ๋ฒค์น˜์— ๋ˆ•ํžˆ๊ณ 
ํ™”์‚ดํ‘œ๋Š” ์‰ฌ๋„๋ก, ํ•œ์ˆจ ๋Œ๋ฆฌ๋‹ˆ
์ฝ”๋“œ ๋ฐญ์— ํ–‡์‚ด ํ•œ ์ค„๊ธฐ ๋ฐ˜์ง๋ฐ˜์ง


๐Ÿ“œ Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 8c9abaf and 1423b33.

๐Ÿ“’ Files selected for processing (2)
  • src/pages/community/components/CommunityContents.tsx (1 hunks)
  • src/pages/community/components/CommunityLeftSide.tsx (1 hunks)
โœจ Finishing Touches
  • ๐Ÿ“ Generate Docstrings
๐Ÿงช Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bug/qa-332

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Chasyuss Chasyuss merged commit 0ceac2f into develop Sep 7, 2025
1 check passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

๐Ÿงน Nitpick comments (3)
src/common/CheckList.tsx (1)

292-300: ToastModal ๋„ˆ๋น„ ์ถ•์†Œ ๋ฐ˜์˜ OK. ๋‹ค๊ตญ์–ด/์ค„๋ฐ”๊ฟˆ ์‹œ ๋ ˆ์ด์•„์›ƒ ๊นจ์ง๋งŒ ํ™•์ธ ๋ถ€ํƒ

๊ธด ํ…์ŠคํŠธ(์˜ˆ: ๋ฒˆ์—ญ)์—์„œ ๋ฒ„ํŠผ ์˜์—ญ์ด ์ค„๋ฐ”๊ฟˆ์œผ๋กœ ๋ฐ€๋ฆฌ์ง€ ์•Š๋Š”์ง€ ํ•œ๋ฒˆ ํ™•์ธํ•ด ์ฃผ์„ธ์š”. ํ•„์š” ์‹œ ๋ฐ˜์‘ํ˜• ํด๋ž˜์Šค๋กœ ์•ˆ์ „์žฅ์น˜ ๊ถŒ์žฅ.

๊ฐ€๋Šฅํ•œ ๋Œ€์•ˆ:

-            width="w-[350px]"
+            width="max-w-[350px] w-auto md:w-[350px]"
src/hook/useJobQuery.ts (1)

170-177: ์ธ์ฆ ํ—ค๋”์— 'Bearer null' ์ „์†ก ๊ฐ€๋Šฅ์„ฑ ์ฐจ๋‹จ ๊ถŒ์žฅ

ํ† ํฐ์ด ์—†์„ ๋•Œ๋„ Authorization ํ—ค๋”๊ฐ€ ์ „์†ก๋  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ์กฐ๊ฑด๋ถ€ ํ—ค๋”๋กœ ๋ฐฉ์ง€ํ•ด ์ฃผ์„ธ์š”. ๋ฐฑ์—”๋“œ๊ฐ€ ๋น„๋กœ๊ทธ์ธ ์ ‘๊ทผ์„ ํ—ˆ์šฉํ•˜๋Š”์ง€๋„ ํ™•์ธ ๋ฐ”๋ž๋‹ˆ๋‹ค.

-  const token = localStorage.getItem('accessToken');
-  const response = await api.get(`/v1/todo/other/simple/${todoGroupId}`, {
-    headers: {
-      Authorization: `Bearer ${token}`,
-    },
-  });
+  const token = localStorage.getItem('accessToken');
+  const headers = token ? { Authorization: `Bearer ${token}` } : undefined;
+  const response = await api.get(`/v1/todo/other/simple/${todoGroupId}`, {
+    headers,
+  });
src/pages/jobDetail/components/ProfileCard.tsx (1)

16-19: ์กฐํšŒ ๊ธฐ์ค€ ์ „ํ™˜ ํ™•์ธ ํ•„์š”: ๋งํฌ ์ด๋™์€ ์—ฌ์ „ํžˆ jobId ์‚ฌ์šฉ

๋ชฉ๋ก ๋ฐ์ดํ„ฐ๋Š” todoGroupId๋กœ ๊ฐ€์ ธ์˜ค์ง€๋งŒ ์ƒ๋‹จ "๋” ๋ณด๋Ÿฌ๊ฐ€๊ธฐ"๋Š” /others/${jobId}๋กœ ์ด๋™ํ•ฉ๋‹ˆ๋‹ค. ์˜๋„(์ง์—… ๊ธฐ์ค€ ํŽ˜์ด์ง€ ์ด๋™)๊ฐ€ ๋งž๋Š”์ง€ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค. ๋งŒ์•ฝ ๊ทธ๋ฃน ๊ธฐ์ค€ ์ด๋™์ด์–ด์•ผ ํ•˜๋ฉด ๋ผ์šฐํŒ… ํŒŒ๋ผ๋ฏธํ„ฐ๋„ ์ •ํ•ฉ์„ฑ ๋งž์ถฐ์ฃผ์„ธ์š”.

๐Ÿ“œ Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 694d0c1 and 8c9abaf.

๐Ÿ“’ Files selected for processing (6)
  • src/common/CheckList.tsx (1 hunks)
  • src/hook/jobinfo/useJobTodoCategory.ts (0 hunks)
  • src/hook/useJobQuery.ts (2 hunks)
  • src/pages/jobDetail/components/ProfileCard.tsx (1 hunks)
  • src/pages/jobDetail/components/RecommendTodo.tsx (0 hunks)
  • src/pages/otherTodoList/OtherTodoListPage.tsx (1 hunks)
๐Ÿ’ค Files with no reviewable changes (2)
  • src/pages/jobDetail/components/RecommendTodo.tsx
  • src/hook/jobinfo/useJobTodoCategory.ts
๐Ÿ”‡ Additional comments (3)
src/hook/useJobQuery.ts (1)

185-189: todoGroupId ๊ธฐ๋ฐ˜์œผ๋กœ์˜ ์ฟผ๋ฆฌ ์ „ํ™˜ LGTM

์ฟผ๋ฆฌ ํ‚ค์™€ ํŒŒ๋ผ๋ฏธํ„ฐ ๋ชจ๋‘ ์ผ๊ด€์„ฑ ์žˆ๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์–ด ์บ์‹œ ์ถฉ๋Œ ์šฐ๋ ค ์—†์Šต๋‹ˆ๋‹ค.

src/pages/otherTodoList/OtherTodoListPage.tsx (1)

111-116: ProfileCard์— todoGroupId ์ „๋‹ฌ ๋ณ€๊ฒฝ LGTM

๋ฐ์ดํ„ฐ ๋ชจ๋ธ(eachTodos.todoGroupId)๊ณผ ์ปดํฌ๋„ŒํŠธ prop์ด ์ผ์น˜ํ•ฉ๋‹ˆ๋‹ค.

src/pages/jobDetail/components/ProfileCard.tsx (1)

12-13: ์ƒˆ prop(todoGroupId) ์ถ”๊ฐ€ ๋ฐ˜์˜ LGTM

ํƒ€์ดํ•‘๊ณผ ์‚ฌ์šฉ์ฒ˜ ์ผ๊ด€์„ฑ ๋ฌธ์ œ์—†์Šต๋‹ˆ๋‹ค.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants