Skip to content

Conversation

@samaloney
Copy link
Member

Closes #198

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.53%. Comparing base (3c8b7d6) to head (1261b8e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   81.36%   81.53%   +0.17%     
==========================================
  Files          36       36              
  Lines        2458     2459       +1     
==========================================
+ Hits         2000     2005       +5     
+ Misses        458      454       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the get_data method where applying a pixel mask to data with fewer than 12 pixels would cause a shape mismatch error.

  • Fixed pixel mask slicing to handle data with less than 12 pixels
  • Added test case for pixel_indices parameter

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
stixpy/product/sources/science.py Modified pixel mask application to slice the mask to match actual number of pixels in the data
stixpy/product/sources/tests/test_science.py Added test for get_data with pixel_indices parameter
changelog/200.bugfix.rst Documented the bug fix in the changelog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samaloney samaloney merged commit a53368c into TCDSolar:main Nov 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CPD get_data pixel_indices broken for requests with less then 12 pixels

1 participant