Refactor some of the plotting code#181
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 80.97% 81.36% +0.39%
==========================================
Files 35 36 +1
Lines 2391 2458 +67
==========================================
+ Hits 1936 2000 +64
- Misses 455 458 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the plotting code by extracting pixel plotting functionality from the PixelPlotMixin class into a new dedicated PixelPlotter class to improve code organization and follow the single responsibility principle.
- Creates a new
PixelPlotterclass that handles all pixel plotting logic - Simplifies the
PixelPlotMixinby delegating to the new plotter class - Enables animation capabilities for pixel plots through the cleaner separation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| stixpy/visualisation/plotters.py | New file containing the extracted PixelPlotter class and SliderCustomValue helper |
| stixpy/product/sources/science.py | Refactored to use the new PixelPlotter class and removed extensive plotting code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ddd3653 to
ad0de9c
Compare
nicHoch
left a comment
There was a problem hiding this comment.
good rework - better structure now for more plotting to come
ad0de9c to
aa8749e
Compare
Refactor to move plotting code out of products to simplify and try to keep single reponssiblty principle a bit more closes #180.
test2.mp4