Skip to content

Conversation

@jajmitchell
Copy link

@jajmitchell jajmitchell commented Aug 20, 2025

Hosts STIX drm within STIXpy

This adds the STIX drm to STIXpy and builds out the pipeline to create an SRM within STIXpy that can be used for spectral analysis.

Creates /data and adds drm
Replaces .fits with .npy file
Adds changelog
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.71%. Comparing base (54c0e5f) to head (249a854).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   75.43%   80.71%   +5.28%     
==========================================
  Files          33       34       +1     
  Lines        2117     2313     +196     
==========================================
+ Hits         1597     1867     +270     
+ Misses        520      446      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samaloney
Copy link
Member

The files are way to big they should probably live in STIX-CONF or similar it a bug they pre-commit didn't find this max files size ~1054kb

Removes .fits file
Copy link
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need some code to read in the drm and return an nice object for moment could just be the matrix and the two axis (photon and count) as quantities

@samaloney
Copy link
Member

We just redefined the energy grid used to create the DRM in IDL

@DanRyanIrish
Copy link
Contributor

For that reason, I think we need to allow users to provide their own DRM, rather than only being able to use the DRM that happened to be attached to a specific version of STIXpy

@samaloney samaloney modified the milestones: v0.4.0, v0.3.0 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants