-
Notifications
You must be signed in to change notification settings - Fork 24
Hosts STIX drm within STIXpy #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Creates /data and adds drm
Replaces .fits with .npy file
Adds changelog
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 75.43% 80.71% +5.28%
==========================================
Files 33 34 +1
Lines 2117 2313 +196
==========================================
+ Hits 1597 1867 +270
+ Misses 520 446 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The files are way to big they should probably live in STIX-CONF or similar it a bug they pre-commit didn't find this max files size ~1054kb |
Removes .fits file
samaloney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need some code to read in the drm and return an nice object for moment could just be the matrix and the two axis (photon and count) as quantities
|
We just redefined the energy grid used to create the DRM in IDL |
|
For that reason, I think we need to allow users to provide their own DRM, rather than only being able to use the DRM that happened to be attached to a specific version of STIXpy |
Hosts STIX drm within STIXpy
This adds the STIX drm to STIXpy and builds out the pipeline to create an SRM within STIXpy that can be used for spectral analysis.