Skip to content

Make calibrated_visibilities store flare location at phase_center, ra… #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanRyanIrish wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make calibrated_visibilities store flare location at phase_center, ra… #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eaf3df
Make calibrated_visibilities store flare location at phase_center, ra…
DanRyanIrish Nov 19, 2024
a054aa2
Make default flare location s SkyCood in STIXImaging frame instead of…
DanRyanIrish Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stixpy/calibration/visibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def get_uv_points_data(d_det: u.Quantity[u.mm] = 47.78 * u.mm, d_sep: u.Quantity
return uv_data


def calibrate_visibility(vis: Visibilities, flare_location: SkyCoord = STIXImaging(0 * u.arcsec, 0 * u.arcsec)):
def calibrate_visibility(vis: Visibilities, flare_location: SkyCoord = SkyCoord(Tx=0 * u.arcsec, Ty=0 * u.arcsec, frame=STIXImaging)):
"""
Calibrate visibility phase and amplitudes.

Expand Down Expand Up @@ -442,11 +442,11 @@ def calibrate_visibility(vis: Visibilities, flare_location: SkyCoord = STIXImagi
calibrated_visibility = (np.cos(calibrated_phase) + np.sin(calibrated_phase) * 1j) * calibrated_amplitude

vis.meta["calibrated"] = True
vis.meta["offset"] = flare_location
cal_vis = Visibilities(
calibrated_visibility,
u=vis.u,
v=vis.v,
phase_center=flare_location,
amplitude=calibrated_amplitude,
amplitude_uncertainty=calibrated_amplitude_error,
meta=vis.meta,
Expand Down
Loading