Skip to content

Conversation

@DanRyanIrish
Copy link
Contributor

This PR proposes some convenience tools for condensing a some common tasks that are mostly well-defined but currently take many lines of code.

@DanRyanIrish
Copy link
Contributor Author

@samaloney Would something like this be within scope for STIXpy?

w2.wcs.set()
return w2

def to_hpc(self,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a transform like any other so we should do it via the standard API can include this shortcut in the transformation code I think - need to think about this a bit more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think that makes sense.

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 23.88060% with 51 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (5dbfc0b) to head (7f57d78).

Files with missing lines Patch % Lines
stixpy/imaging/tools.py 22.41% 45 Missing ⚠️
stixpy/map/stix.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   73.56%   71.96%   -1.60%     
==========================================
  Files          32       33       +1     
  Lines        2016     2083      +67     
==========================================
+ Hits         1483     1499      +16     
- Misses        533      584      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants