Add components for VS and VS Code icons #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deqyra
force-pushed
the
add_VS_and_VSCode_icons
branch
2 times, most recently
from
7ef990d to
8006cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #17 (which is to be reviewed and merged before this one, cc @jeremy-rifkin) and adds two inline icons for VS and VS Code.
Markup:
Result:
Notice:
Using those icons (and InlineIcon in general) in Markdown causes janky line breaks in the rendered HTML. A bug report about it was opened and accepted, so I guess we can live with it until it is fixed upstream?