Explain why auto-deletion didn't take place #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jeremy-rifkin
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, the current message is grammatically incorrect:
This happens because we combine
${action} message from, which doesn't fit whenactionis "Auto-delete threshold reached.Secondly, the message is a bit unintuitive. I didn't understand that "threshold reached" implies that no deletion takes place. After all, when the threshold is reached, things get deleted, right?
The new message clearly states that deletion doesn't take place, and provides a reason as to why (which may be quite useful for debugging).
I wrote this whole PR in the GitHub editor without testing anything so there's a good chance this doesn't even work, might need to try locally.