Skip to content

HyperLTL trace error - fix 2127914 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtygesen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

HyperLTL trace error - fix 2127914 #213

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ed5003
fixed some traces reporting as finite even though they contain a loop
mtygesen Oct 29, 2025
4c878f6
fix popping before processing
mtygesen Nov 12, 2025
51b9032
fix test failing
mtygesen Nov 12, 2025
6143f3d
Merge branch 'TAPAAL:main' into hyperltl-trace-loop-error-2127914
mtygesen Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 25 additions & 33 deletions src/LTL/Algorithm/NestedDepthFirstSearch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,43 +218,35 @@ namespace LTL {


template<typename T>
void NestedDepthFirstSearch::build_trace(light_deque<stack_entry_t<T>>& todo, light_deque<stack_entry_t<T>>& nested_todo)
{
size_t loop_id = std::numeric_limits<size_t>::max();
// last element of todo-stack always has a "garbage" transition, it is the
// current working element OR first element of nested.
void NestedDepthFirstSearch::build_trace(light_deque<stack_entry_t<T>>& todo, light_deque<stack_entry_t<T>>& nested_todo) {
if (!todo.empty()) todo.pop_back();
while (!todo.empty()) {
const auto& top = todo.front();
const auto res = top._sucinfo.transition();
if constexpr (std::is_same<std::decay_t<decltype(res)>, std::vector<uint32_t>>::value) {
_trace.emplace_back(res);
} else {
_trace.push_back({res});
assert(res < _net.numberOfTransitions());
}

if(!todo.empty())
todo.pop_back();
if(!nested_todo.empty()) {
// here the last state is significant
// of the successor is the check that demonstrates the violation.
loop_id = nested_todo.back()._id;
nested_todo.pop_back();
todo.pop_front();
}

for(auto* stck : {&todo, &nested_todo})
{
while(!(*stck).empty())
{
auto& top = (*stck).front();
if(top._id == loop_id)
{
_loop = _trace.size();
loop_id = std::numeric_limits<size_t>::max();
}
auto res = top._sucinfo.transition();
if constexpr (std::is_same<decltype(res),std::vector<uint32_t>>::value)
{
_trace.emplace_back(top._sucinfo.transition());
}
else
{
_trace.push_back({top._sucinfo.transition()});
assert(top._sucinfo.transition() < _net.numberOfTransitions());
}
(*stck).pop_front();
_loop = _trace.size();
if (nested_todo.empty()) return;
while (!nested_todo.empty()) {
const auto& top = nested_todo.front();
const auto res = top._sucinfo.transition();
if constexpr (std::is_same<std::decay_t<decltype(res)>, std::vector<uint32_t>>::value) {
_trace.emplace_back(res);
} else if (res < _net.numberOfTransitions()) {
_trace.push_back({res});
} else {
break;
}

nested_todo.pop_front();
}
}
}
Loading