SMC custom distributions

[mtygesen]

• Adds support for custom distributions to the GUI

[srba]

Custom should not be under discrete distribution. I think that perhaps it should be a third toggle option with custom. When you select it, there should be a dropdown menu with already declared custom distributions from which you can select it. There should also be a button "Manage custom distribution" if you toggle custom distribution. This should open a new menu that will allow to add and delete custom distribution to a drop down menu. When you add a new one, you should be able to give it a name and load it from a file. The file dialog should be the same as if you e.g. open a net - right now the file dialog does not use the native window for locating a file.
The path to the file from where the distribution was loaded should not be displayed/remembered anywhere. There should be also an option to see the values in the distributions and to explore them, possibly edit.

[srba]

Once you click on Add new distribution, ask only for the name but then show the Edit window directly where the user can add the values manually. Add the also a button "Load from a file" to this dialog that will open the file dialog and populate the text field with the values from the file.
Also, when you click on "Manage distributions", select (put focus on) the first distribution on the list automatically.
Finally, show the density function looks weird. If I enter e.g. the values 1 2 3 4 5 then it shows that last value with higher probability.

[srba]

The visualization still does not work, if you enter e.g. the values 1, 2, 3, 4, 5 on the x-axis they will show at 1.4, 2.2, 3.8 and 4.6 but not at the correct values.

Also, to the dialog, please add that we need one number per line
"Enter values (one real number per line) for ... "

[srba]

For urgent transitions it should not be allowed to select custom distribution - open e.g. fireflies and double-click on some urgent transition to see that custom distributions are enabled.

Also, if you make two custom distributions and and choose one and then go to manage distributions and rename the currently selected distribution, then after finishing the custom distribution in the dropdown menu jumps to the other one (but it should show the renamed distribution)

Finally, if you want to add a new distribution to the list, the dialog with the name of the distrubution looks different than normally as it shows the TAPAAL logo. Maybe we could do without it.

Also, the "Edit values (one real number per ...)" does not all show - we need to make the window wider I think

[srba]

The query dialog got too wide (and it increases length if you change from continuous/discrete to custom distribution. We need to have it more narrow so that it fits on the laptop screen.

Also, in the "Mange distribution" if you click on "close" the currently highlighted distribution will get replaced as the current one - even though initially another one was selected in the dropdown menu next to custom distributions. Closing the dialog should now just rewrite the the previously selected value - one should be able to do so only in the dropdown menu.

[srba]

The dialog looks good now. But I found another issue:

You can in the dialog select custom distribution and not define any distribution and click ok. The transition will now say custom(null) distribution and the verification will fail (check e.g. on fireflies). Similarly, if you created a custom distribution but in the "manage distributions" you actually delete it and then close the dialog and press "ok", you have again "custom(null)" distribution which gives verification error.

[srba]

It is still possible to enter costum distribution with (null) argument.
Open e.g. fireflies, open some transition, select "custom" and then click on e.g. <*> or on the button "reset expression" and the "OK" button now gets enabled and you can save it with (null) which gives verification problem.

[srba]

Looks good to me.