-
Notifications
You must be signed in to change notification settings - Fork 0
Remove libsrt dependency and integrate compilation into build process #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of C++, is there somewhere in particular I should look to see where you integrate it into build process?
you have to look in the most of the C++ and header files are just copied directly from the srt repo |
Co-authored-by: Grant Keiser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My machine is missing srt.h so I cannot build. Should there be something in the readme about where/how to get set up for development/building?
you shouldn't need anything in order to build this, except libssl and libcrypto |
I'm having trouble seeing the advantage of this. The last commit states a One of the motivations for switching from UDT to SRT was UDT was no longer maintained and building it was a PITA. How will updates to srtgo be managed? Won't this just become another PITA too? |
This does seem like it sets us up for an extremely difficult upgrade path. |
I discussed with Sam and he still sees the worth of doing this, as opposed to having everybody install/build libsrt |
Uses golang c bindings to integrate the srt library directly into the srtgo library so that libsrt is no longer required.