-
Notifications
You must be signed in to change notification settings - Fork 24
Update docs and add doctests #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
@@ -31,14 +32,15 @@ end | |||
makedocs(; | |||
modules=[DynamicQuantities, DynamicQuantities.Units], | |||
authors="MilesCranmer <[email protected]> and contributors", | |||
repo="https://github.com/SymbolicML/DynamicQuantities.jl/blob/{commit}{path}#{line}", | |||
repo=GitHub("SymbolicML/DynamicQuantities.jl"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the deploydocs
call later in the file (two of them) also need a GitHub
object for consistency? I'm assuming the repo
kwarg takes the same type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems deploydocs()
is asking for a string for repo=
rather than a GitHub
object (https://documenter.juliadocs.org/stable/lib/public/#Documenter.deploydocs)
Please see the commmit messages for relevant changes