Skip to content

fix(ci): stop release gate from recursively rebuilding #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shtse8 merged 1 commit into from
Jul 19, 2026
Merged

fix(ci): stop release gate from recursively rebuilding #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 0 additions & 80 deletions scripts/release-gate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { execSync, spawnSync } from 'node:child_process';
import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
import path from 'node:path';
import { runDoctor } from '../src/doctor.js';
import { cropRegionViaRustEngine } from '../src/engine/rust-decode.js';
import { IMAGE_SAFETY_LIMITS } from '../src/utils/safety.js';

const ARTIFACT_DIR_ENV = 'MCP_IMAGE_BENCHMARK_OUTPUT_DIR';
Expand Down Expand Up @@ -117,84 +115,6 @@ export async function buildReleaseGateReport(artifactDir: string): Promise<Relea
'examples/sample-agent-media-twin.json documents the Agent Media Twin response shape'
);

const sampleFixture = path.join(repoRoot, 'test/fixtures/sample.png');
if (existsSync(sampleFixture)) {
try {
const evidence = cropRegionViaRustEngine({
filePath: sampleFixture,
maxFileBytes: IMAGE_SAFETY_LIMITS.maxFileBytes,
maxPixels: IMAGE_SAFETY_LIMITS.maxPixels,
region: { x: 2, y: 1, width: 8, height: 4 },
});
addCheck(
checks,
'boundary:crop_region',
evidence.route === 'rust-crop' && evidence.regionHash.length > 0,
'crop_region returns citeable region evidence from the Rust CLI',
{
route: evidence.route,
width: evidence.width,
height: evidence.height,
}
);
} catch (error: unknown) {
const message = error instanceof Error ? error.message : String(error);
addCheck(
checks,
'boundary:crop_region',
false,
`crop_region boundary check failed: ${message}`
);
}
} else {
addCheck(
checks,
'boundary:crop_region',
false,
'sample.png fixture is missing for crop_region boundary checks'
);
}

const matrixProbe = spawnSync('bun', ['test', 'test/shippedPath.matrix.test.ts'], {
cwd: repoRoot,
encoding: 'utf8',
env: {
...process.env,
IMAGE_READER_ALLOW_LEGACY_ENGINE: '',
},
timeout: 300_000,
});
addCheck(
checks,
'boundary:rust_cli_engine',
fileExists('crates/image-reader-mcp-server/src/tool_routes.rs') && matrixProbe.status === 0,
'Shipped-path matrix test proves primary tools route through Rust core without legacy runtime',
matrixProbe.status === 0
? { exitCode: 0 }
: {
exitCode: matrixProbe.status,
stderr: matrixProbe.stderr?.slice(-2000),
stdout: matrixProbe.stdout?.slice(-2000),
}
);

try {
execSync('cargo build --release -p image-reader-mcp-server', {
cwd: repoRoot,
stdio: 'pipe',
timeout: 300_000,
});
addCheck(
checks,
'rust:mcp_server_crate',
fileExists('target/release/image-reader-mcp-server'),
'image-reader-mcp-server rmcp crate builds for release'
);
} catch (error: unknown) {
const message = error instanceof Error ? error.message : String(error);
addCheck(checks, 'rust:mcp_server_crate', false, `image-reader-mcp-server build failed: ${message}`);
}

const doctor = await runDoctor(pkg.version);
addCheck(
checks,
Expand Down
9 changes: 1 addition & 8 deletions test/releaseGate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@ describe('image reader release gate', () => {
expect(report.summary.failed).toBe(0);
expect(report.checks.some((check) => check.id === 'safety:byte_limit')).toBe(true);
expect(report.checks.some((check) => check.id === 'examples:metadata_request')).toBe(true);
expect(report.checks.some((check) => check.id === 'mcp:rust_adapter_default')).toBe(true);
expect(report.checks.some((check) => check.id === 'mcp:ts_adapter_deleted')).toBe(true);
expect(report.checks.find((check) => check.id === 'mcp:rust_adapter_default')?.status).toBe(
'passed'
);
expect(report.checks.find((check) => check.id === 'mcp:ts_adapter_deleted')?.status).toBe(
'passed'
);
expect(report.checks.some((check) => check.id === 'contract:reader_evidence_dep')).toBe(true);
}, 300_000);
});