Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,5 @@ jobs:
- name: Run tests
run: bun test

- name: Public surface audit (README discovery)
run: bun test test/readmeDiscovery.test.ts

- name: Release gate
run: bun run benchmark:release-gate
run: bun run benchmark:release-gate
17 changes: 1 addition & 16 deletions crates/image-reader-mcp-server/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,25 +66,10 @@ impl ServerHandler for ImageReaderMcp {
#[cfg(test)]
mod tests {
use super::ImageReaderMcp;
use std::fs;
use std::path::PathBuf;

#[test]
fn rmcp_server_sources_route_read_image_through_rust_core() {
let src_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("src");
let lib_rs = fs::read_to_string(src_dir.join("lib.rs")).expect("read lib.rs");
let production_lib = lib_rs.split("#[cfg(test)]").next().unwrap_or(&lib_rs);
assert!(production_lib.contains("read_image::read_image"));

let routes = fs::read_to_string(src_dir.join("tool_routes.rs")).expect("read tool_routes");
assert!(routes.contains("read_image"));
assert!(routes.contains("RustCore"));
}

#[test]
fn exposes_read_image_tool_surface() {
let tools = ImageReaderMcp::new().tool_router.list_all();
let names: Vec<_> = tools.iter().map(|tool| tool.name.to_string()).collect();
assert!(names.contains(&"read_image".to_string()));
}
}
}
6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,15 @@
"format": "biome format --write .",
"check": "biome check .",
"check:fix": "biome check --write .",
"check:ts-adapter-deleted": "bash scripts/check-ts-adapter-deletion-ready.sh",
"check:no-ts-stdio-mcp": "bash scripts/check-no-ts-stdio-mcp.sh",
"validate": "bun run check && bun run typecheck && bun run test && bun run check:ts-adapter-deleted && bun run check:no-ts-stdio-mcp",
"validate": "bun run check && bun run typecheck && bun run test",
"doctor": "bun run src/doctor-cli.ts",
"benchmark:release-gate": "bun scripts/release-gate.ts",
"sync:server-json": "bun scripts/sync-server-json.ts",
"version-packages": "changeset version && bun run sync:server-json",
"start": "./bin/image-reader-mcp",
"clean": "rm -rf dist coverage",
"prepublishOnly": "bun run clean && bun run build && bun run build:rust",
"release": "bun run typecheck && bun run check && bun run build && bun test && bun run check:ts-adapter-deleted && changeset publish"
"release": "bun run typecheck && bun run check && bun run build && bun test && changeset publish"
},
"dependencies": {
"@sylphx/reader-evidence": "github:SylphxAI/reader-evidence",
Expand Down
96 changes: 0 additions & 96 deletions scripts/check-no-ts-stdio-mcp.sh

This file was deleted.

59 changes: 0 additions & 59 deletions scripts/check-ts-adapter-deletion-ready.sh

This file was deleted.

51 changes: 1 addition & 50 deletions scripts/release-gate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,6 @@ export async function buildReleaseGateReport(artifactDir: string): Promise<Relea
'Rust image-reader-core decode engine is present',
);

addCheck(
checks,
'rust:crop_region_core',
fileExists('crates/image-reader-core/src/lib.rs') &&
readFileSync(path.join(repoRoot, 'crates/image-reader-core/src/lib.rs'), 'utf8').includes(
'pub fn crop_region'
),
'Rust image-reader-core exposes crop_region for region evidence',
);

addCheck(
checks,
'safety:pixel_limit',
Expand Down Expand Up @@ -165,45 +155,6 @@ export async function buildReleaseGateReport(artifactDir: string): Promise<Relea
);
}

const binWrapper = readFileSync(path.join(repoRoot, 'bin/image-reader-mcp'), 'utf8');
addCheck(
checks,
'mcp:rust_adapter_default',
binWrapper.includes('image-reader-mcp-server') &&
binWrapper.includes('resolve_rust_bin') &&
binWrapper.includes('resolve_transport') &&
!binWrapper.includes('use_ts_transport') &&
!binWrapper.includes('exec node') &&
!binWrapper.includes('dist/index.js') &&
!existsSync(path.join(repoRoot, 'src/index.ts')),
'Default npm bin launches the Rust rmcp MCP server only; TypeScript stdio adapter is deleted'
);

addCheck(
checks,
'mcp:ts_adapter_deleted',
!existsSync(path.join(repoRoot, 'src/index.ts')) &&
!existsSync(path.join(repoRoot, 'dist/index.js')) &&
existsSync(path.join(repoRoot, 'src/doctor-cli.ts')) &&
existsSync(path.join(repoRoot, 'scripts/check-ts-adapter-deletion-ready.sh')) &&
existsSync(path.join(repoRoot, 'scripts/check-no-ts-stdio-mcp.sh')),
'TS stdio adapter entry is deleted; doctor-cli and deletion gates are present'
);

const httpTransportSource = readFileSync(
path.join(repoRoot, 'crates/image-reader-mcp-server/src/http_transport.rs'),
'utf8'
);
addCheck(
checks,
'mcp:rust_web_http_transport',
httpTransportSource.includes('StreamableHttpService') &&
httpTransportSource.includes('/mcp/health') &&
binWrapper.includes('resolve_transport') &&
binWrapper.includes('MCP_TRANSPORT=http'),
'Rust rmcp streamable HTTP Web MCP transport is wired; npm bin routes MCP_TRANSPORT=http to Rust'
);

const matrixProbe = spawnSync('bun', ['test', 'test/shippedPath.matrix.test.ts'], {
cwd: repoRoot,
encoding: 'utf8',
Expand Down Expand Up @@ -312,4 +263,4 @@ if (import.meta.main) {
console.error(error);
process.exit(1);
});
}
}
28 changes: 0 additions & 28 deletions test/httpTransport.matrix.test.ts

This file was deleted.

40 changes: 0 additions & 40 deletions test/readmeDiscovery.test.ts

This file was deleted.

11 changes: 0 additions & 11 deletions test/rustDecode.boundary.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,4 @@ describe('rust decode engine boundary', () => {
expect(twin.region_evidence?.dimensions).toEqual({ width: 10, height: 6 });
expect(twin.region_evidence?.region_hash.length).toBeGreaterThan(0);
});

it('keeps decode logic out of the TypeScript adapter sources', async () => {
const { readFileSync } = await import('node:fs');
const handlerSrc = readFileSync(path.join(repoRoot, 'src/handlers/readImage.ts'), 'utf8');
const engineSrc = readFileSync(path.join(repoRoot, 'src/engine/rust-decode.ts'), 'utf8');

expect(engineSrc).toContain('spawnSync');
expect(handlerSrc).toContain('probeImageViaRustEngine');
expect(handlerSrc).toContain('cropRegionViaRustEngine');
expect(handlerSrc).not.toMatch(/sha256|ImageReader|guess_format/i);
});
});
Loading
Loading