Skip to content

ci: require static owned admission runner #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shtse8 merged 1 commit into from
Jul 27, 2026
Merged

ci: require static owned admission runner #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/adr29-admission.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ on:
type: string
required: false
default: adr29-admission-manifest.json
runs-on:
description: Approved Sylphx runner profile for the admission job.
type: string
required: false
default: sylphx-linux-standard
base-ref:
description: Base ref for diff calculation.
type: string
Expand Down Expand Up @@ -76,7 +71,7 @@ permissions:
jobs:
admission:
name: ${{ inputs.check-name }}
runs-on: [self-hosted, "${{ inputs.runs-on }}"]
runs-on: sylphx-linux-standard
steps:
- name: Checkout caller repository
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/project-control.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,14 @@ jobs:
reusable=.github/workflows/adr29-admission.yml
template=templates/workflows/adr29-admission.yml
project_control=.github/workflows/project-control.yml
test "$(grep -Ec '^[[:space:]]*default:[[:space:]]*sylphx-linux-standard$' "$reusable")" -eq 1
grep -Eq '^[[:space:]]*runs-on:[[:space:]]*\[self-hosted,[[:space:]]*"[$][{][{][[:space:]]*inputs\.runs-on[[:space:]]*[}][}]"[[:space:]]*\]$' "$reusable"
test "$(grep -Ec '^[[:space:]]*runs-on:' "$reusable")" -eq 1
test "$(grep -Ec '^[[:space:]]*runs-on:[[:space:]]*sylphx-linux-standard$' "$reusable")" -eq 1
test "$(grep -Ec '^[[:space:]]*runs-on:' "$template")" -eq 4
test "$(grep -Ec '^[[:space:]]*runs-on:[[:space:]]*sylphx-linux-standard$' "$template")" -eq 4
grep -Eq '^[[:space:]]*runs-on:[[:space:]]*sylphx-linux-standard$' "$project_control"
if grep -REn '^[[:space:]]*runs-on:[[:space:]]*(ubuntu|macos|windows)-' "$reusable" "$template" "$project_control"; then
echo '::error::GitHub-hosted runner declarations are not allowed in ADR-29 policy surfaces'
test "$(grep -Ec '^[[:space:]]*runs-on:' "$project_control")" -eq 1
test "$(grep -Ec '^[[:space:]]*runs-on:[[:space:]]*sylphx-linux-standard$' "$project_control")" -eq 1
if grep -REn '^[[:space:]]*runs-on:[[:space:]]*.*[$][{][{]' "$reusable" "$template" "$project_control"; then
echo '::error::dynamic runner declarations are not allowed in ADR-29 policy surfaces'
exit 1
fi
- name: Check Changesets publisher syntax
Expand Down
Loading