Fix - Use operation name by default for the route name #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
fix/use-operation-name-when-specified
branch
from
6285417 to
75038dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an HttpOperation, the name of the operation is used to store the route name. (a CLI operation which does not exist yet could use the name for the command name, that's why the "name" is kind generic).
On OperationRouteNameFactory, it builds the route name based on other properties even if the name is already defined.
We need that fix here
https://github.com/Sylius/Sylius/pull/17695/files#r1971186393 for this route https://github.com/Sylius/Sylius/blob/2.1/src/Sylius/Bundle/AdminBundle/Resources/config/routing/inventory.yml