Resource route collection factory #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Feb 21, 2025
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
force-pushed
the
resource-route-collection-factory
branch
from
66c90b2 to
444010d
Compare
loic425
commented
Feb 21, 2025
| use Symfony\Component\Routing\Route; | ||
| use Symfony\Component\Routing\RouteCollection; | ||
| use Webmozart\Assert\Assert; | ||
|
|
||
| trigger_deprecation('sylius/resource', '1.13', '"%s" is deprecated, use "%s" instead.', AttributesOperationRouteFactory::class, ResourceRouteCollectionFactory::class); |
There was a problem hiding this comment.
I'm wondering if I should deprecate the service instead, cause maybe the user will not be able to remove that deprecation message.
loic425
force-pushed
the
resource-route-collection-factory
branch
3 times, most recently
from
0d67aae to
3603e04
Compare
loic425
commented
Feb 25, 2025
| @@ -1,7 +1,11 @@ | |||
| sylius_crud_routes: | |||
| resource: 'sylius.routing.loader.crud_routes_attributes' | |||
| type: service | |||
| # | |||
| #sylius_routes: | |||
| # resource: 'sylius.routing.loader.routes_attributes' | |||
There was a problem hiding this comment.
we have to deprecate the service
loic425
force-pushed
the
resource-route-collection-factory
branch
from
3603e04 to
85434a6
Compare
loic425
force-pushed
the
resource-route-collection-factory
branch
from
85434a6 to
e55b412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.