Add link script #255
Add link script #255
Conversation
link
Outdated
| * Links dependencies of a project to a local clone of the main Sylius/Stack GitHub repository. | ||
| * Inspired by what Kévin Dunglas <[email protected]> did for symfony/symfony GitHub repository. | ||
| * | ||
| * @author Florian Merle <[email protected]> |
There was a problem hiding this comment.
I think you should update that to match the current one.
/*
* This file is part of the Sylius package.
*
* (c) Sylius Sp. z o.o.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
There was a problem hiding this comment.
I updated the doc blocks. Since it's essentially a copy of the Symfony link file, we should probably use their copyright notice. I also added: (c) Fabien Potencier. What do you think we should do?"
There was a problem hiding this comment.
You should ask @damonsson on Slack.
There was a problem hiding this comment.
We always use only Sylius' copyright information in the project, for example, here is a typical Kernel.php from Symfony 1:1: https://github.com/Sylius/Sylius/blob/2.1/src/Kernel.php
But it could be a great idea to include such information and acknowledgments in the mian README, as it would be more visible to everyone.
There was a problem hiding this comment.
This change would need some docs on how it works and why it's done.
I guess it can be copied from SF as well.
https://github.com/symfony/symfony-docs/pull/8730/files
Do you think this should be part of the documentation of this repository, or in https://github.com/Sylius/Sylius/blob/2.0-docs/docs/the-book/contributing/key-contributors.md ? |
See this merge request Sylius/Sylius#16045