Skip to content

Add parameter to users.id #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j6s wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add parameter to users.id #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abd7c4a
[FIXED]: fixed JSON pasing error on instagram html response.
gate8team May 7, 2014
0282bb8
Add parameter to users.id
Jun 14, 2014
66df80c
Merge branch 'master' of github.com:gate8team/nodestagram
Jun 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,24 @@ InstagramClient.prototype.fetch = function (path, params, callback) {
raw += chunk;
});
res.on('end', function () {
var response = JSON.parse(raw);

var pagination = null;
if (typeof(response['pagination']) != 'undefined') {
pagination = response['pagination'];
}

if (response['meta']['code'] == 200) {
callback(response['data'],
null,
pagination);
}else{
callback(response['meta'], response['meta']['code'], pagination);
}
try{
var response = JSON.parse(raw);

var pagination = null;
if (typeof(response['pagination']) != 'undefined') {
pagination = response['pagination'];
}

if (response['meta']['code'] == 200) {
callback(response['data'],
null,
pagination);
}else{
callback(response['meta'], response['meta']['code'], pagination);
}
} catch (e) {
callback({}, {}, {});
}
});
});
}
Expand Down Expand Up @@ -119,8 +123,15 @@ function InstagramUsersClient (parent) {
this.parent = parent;
}

InstagramUsersClient.prototype.id = function (id, callback) {
this.parent.fetch('/v1/users/'+id, callback);
InstagramUsersClient.prototype.id = function (id, params, callback) {
if (typeof params == "function") {
// be compatible with old implementations, where the second parameter was the callback
callback = params;
this.parent.fetch('/v1/users/' + id, callback);

} else {
this.parent.fetch('/v1/users/' + id, params, callback);
}
}

InstagramUsersClient.prototype.media = function (id, params, callback) {
Expand Down