refactor(web): colocate modules and remove dead scaffolding#2353
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
DRY the release-notes open/close path, mock Google event factory calls, and auth defaults from the schema; inline the DatePicker default-export unwrap and trim restating app-init docs. Co-authored-by: Cursor <cursoragent@cursor.com>
tyler-dane
force-pushed
the
cursor/36e29151
branch
from
July 24, 2026 04:18
8f6e3b9 to
97cdf5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
events.misc,web.test.util,SpaceCharacter,db-errors.util, thin Google auth re-export).calendar.api→api/, cmd constants → CommandPalette,local-event.record→ events, release-notes store → ReleaseNotesPrompt, auth/google env helpers out of generic env).Simplicity
Net complexity down: deleted ~400 lines of dead/misplaced code and colocated the rest. Follow-up simplify commit DRY'd release-notes open/close, Google MSW event helpers, and auth defaults, and fully inlined the DatePicker default-export unwrap. No
useEffect/useRef/useStateadded or removed.Manual Testing Steps
This change is structural (moves/deletes/colocations) with no intentional UI behavior change. Reviewers can spot-check:
Test plan
bun type-checkbun lint(errors clean; existing nursery class-order warnings only)bun test:webfocused suites (app-init, datetime util, google-auth-config, env constants, cmd constants, local-event.record, session.util, google-reconnect toast, AuthModal) — all passingMade with Cursor