Skip to content

refactor(web): colocate modules and remove dead scaffolding#2353

Merged
tyler-dane merged 2 commits into
mainfrom
cursor/36e29151
Jul 24, 2026
Merged

refactor(web): colocate modules and remove dead scaffolding#2353
tyler-dane merged 2 commits into
mainfrom
cursor/36e29151

Conversation

@tyler-dane

Copy link
Copy Markdown
Contributor

Summary

  • Delete dead one-off helpers and core mock fixtures (events.misc, web.test.util, SpaceCharacter, db-errors.util, thin Google auth re-export).
  • Colocate misplaced modules next to their owners (calendar.apiapi/, cmd constants → CommandPalette, local-event.record → events, release-notes store → ReleaseNotesPrompt, auth/google env helpers out of generic env).
  • Slim the release-notes prompt store while keeping reload-survive scheduling and the e2e bridge.

Simplicity

Net complexity down: deleted ~400 lines of dead/misplaced code and colocated the rest. Follow-up simplify commit DRY'd release-notes open/close, Google MSW event helpers, and auth defaults, and fully inlined the DatePicker default-export unwrap. No useEffect / useRef / useState added or removed.

Manual Testing Steps

This change is structural (moves/deletes/colocations) with no intentional UI behavior change. Reviewers can spot-check:

  • Load the week view and confirm all-day event titles still render (trailing non-breaking space preserved)
  • Open the command palette and confirm create/navigation/more commands still appear
  • Confirm Google connect / reconnect still starts the consent flow when Google is configured
  • After a new signup, confirm the release-notes prompt still opens after ~45s (including across a mid-delay reload)

Test plan

  • Correctness review on the cleanup diff — no issues found
  • bun type-check
  • bun lint (errors clean; existing nursery class-order warnings only)
  • bun test:web focused suites (app-init, datetime util, google-auth-config, env constants, cmd constants, local-event.record, session.util, google-reconnect toast, AuthModal) — all passing
  • Simplify follow-up commit with re-verify

Made with Cursor

tyler-dane and others added 2 commits July 23, 2026 22:18
Co-authored-by: Cursor <cursoragent@cursor.com>
DRY the release-notes open/close path, mock Google event factory calls,
and auth defaults from the schema; inline the DatePicker default-export
unwrap and trim restating app-init docs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tyler-dane
tyler-dane merged commit 21bc9f7 into main Jul 24, 2026
19 checks passed
@tyler-dane
tyler-dane deleted the cursor/36e29151 branch July 24, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant