refactor(web): narrow draft reads for drag grid helpers#2352
Merged
Conversation
Add useDraftDragMotion so edge navigation and smart scroll depend on isDragging / draft presence / timed-ness instead of full DraftContext. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useDraftDragMotionexposing onlyisDragging,hasDraft, andisTimedDraft.useDragEdgeNavigationanduseDragEventSmartScrollthrough that hook instead of fulluseDraftContext.Simplicity
Net reduction in coupling: drag grid helpers no longer depend on draft actions or the full local draft object. Hook complexity stayed flat — no new
useEffect/useRef/useStatebeyond the existing ones in the two consumers. Kept existinguseEffects in both helpers because they sync to window mouse listeners and rAF loops.Manual Testing Steps
Test plan
bun test:web packages/web/src/views/Week/components/Grid/MainGrid/MainGrid.test.tsx packages/web/src/views/Week/components/Grid/MainGrid/eventReadOnlyInteraction.test.tsx(24 pass)bun run type-check:web-tests+ web apptsc --noEmitbun lint(pre-existing unused-import warning in__tests__/render-with-store.tsx)Made with Cursor