refactor(web): drop draft context setters for setLocalDraft#2349
Merged
Conversation
Expose setLocalDraft on Week draft actions and remove the public setters bag from DraftContext so callers no longer reach into local state. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setLocalDraft(the local portal draft setter).DraftContextno longer publishes the internalsettersbag;DraftProviderkeeps setters private to actions/effects.Draft.tsxandWeekInteractionCoordinatorcallactions.setLocalDraftinstead ofsetters.setDraft.Simplicity
Net reduction: context value dropped an entire
setterssurface; tests stopped stubbing empty setters. Hook complexity stayed flat — no newuseEffect/useRef/useState.setLocalDraftis a named alias of the existingsetDraftdispatch so the public action matches intent without wrapping behavior.Manual Testing Steps
Test plan
bun test:webfocused Draft/MainGrid/shortcuts suites (53 pass)bun run type-check:web-tests+ web apptsc --noEmitbun lintMade with Cursor