Improve "-threads" command-line argument retrieval, remove "-argv0"#1429
Merged
Conversation
Replaced `atoi` with `Conversion::StringToValue`, and added error checking.
It is no longer used: `ComponentLoader::LoadComponents` stopped using `argv0` with commit c093574, "SK: Some huge changes", Stefan Klein, Feb 12, 2008. The `argv0` parameter was removed from `ComponentLoader::LoadComponents` with commit e72d2b6 "COMP: Fix Clang dangling-gsl warning in LoadComponents...", by me, 10-11-2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added error checking to the "-threads" command-line argument
Removed the internal "-argv0" from the command-line argument map, as it is no longer used:
ComponentLoader::LoadComponentsstopped usingargv0with commit c093574, "SK: Some huge changes", Stefan Klein, Feb 12, 2008.argv0parameter was removed fromComponentLoader::LoadComponentswith commit e72d2b6 "COMP: Fix Clang dangling-gsl warning in LoadComponents...", by me, 10-11-2020