Skip to content

COMP: Restore new GTest targets for ITK > v5.4.5#1428

Merged
N-Dekker merged 1 commit into
mainfrom
Restore-new-GTest-target-names
Apr 10, 2026
Merged

COMP: Restore new GTest targets for ITK > v5.4.5#1428
N-Dekker merged 1 commit into
mainfrom
Restore-new-GTest-target-names

Conversation

@N-Dekker
Copy link
Copy Markdown
Member

Restored support for new GTest target names, that was already introduced with pull request #1408 commit b270116 "COMP: Use GTest::gtest and GTest::gtest_main targets for ITK > v5.4.5"

It was accidentally removed with pull request #1396 commit d3fd241 "ENH: Enable IMPACT as a lazy-loaded plugin (CPU/CUDA)"


@vboussot Please have a look! I think we accidentally removed that piece of CMake code, right?

Restored support for new GTest target names, that was already introduced with pull request #1408 commit b270116 "COMP: Use GTest::gtest and GTest::gtest_main targets for ITK > v5.4.5"

It was accidentally removed with pull request #1396 commit d3fd241 "ENH: Enable IMPACT as a lazy-loaded plugin (CPU/CUDA)"
@N-Dekker N-Dekker merged commit 84e13f8 into main Apr 10, 2026
7 of 8 checks passed
@N-Dekker N-Dekker deleted the Restore-new-GTest-target-names branch April 10, 2026 16:57
@vboussot
Copy link
Copy Markdown
Contributor

Nice catch!
My bad, I merged and kept the wrong version =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants