Fix USE_OpenCLMovingdGenericPyramid typo, restore virtual, improve "ITKimprovements" #include's#1427
Merged
Conversation
Member
N-Dekker
commented
Apr 9, 2026
N-Dekker
commented
- Aiming to pave the way for pull request ENH: Use target based includes #1426
Avoided potential confusion with original ITK header files.
Using Notepad++, Replace in Files, doing:
Find what: "itk(GPUDataManager|GPUFunctorBase|GPUImage|GPUImageDataManager|GPUImageToImageFilter|GPUInPlaceImageFilter|GPUUnaryFunctorImageFilter|OpenCL|OpenCLBuffer|OpenCLCommandQueue|OpenCLContext|OpenCLContextScopeGuard|OpenCLDevice|OpenCLEvent|OpenCLEventList|OpenCLExport|OpenCLExtension|OpenCLGlobal|OpenCLImage|OpenCLImageFormat|OpenCLKernel|OpenCLKernelManager|OpenCLKernelToImageBridge|OpenCLLogger|OpenCLMacro|OpenCLMemoryObject|OpenCLOstreamSupport|OpenCLPlatform|OpenCLProfilingTimeProbe|OpenCLProgram|OpenCLSampler|OpenCLSize|OpenCLStringUtils|OpenCLUserEvent|OpenCLUtil|OpenCLVector|OpenCLVectorBase)\.h"
Replace with: "\.\./ITKimprovements/itk$1\.h"
Filters: *.h;*.cxx;*.hxx
Search Mode: Regular expression
Restored the `virtual` keyword for `AdvancedBSplineDeformableTransformBase::SetCoefficientImages`. which was removed by pull request #1357 commit a533dd9 "STYLE: Make Get/Set CoefficientImages non-virtual, in BSpline Base", merged on Sep 3, 2025, included with 5.3.0 and 5.3.1. Aims to fix: elastix\Common\OpenCL\Filters\itkGPUAdvancedBSplineDeformableTransform.h(70,3): error C3668: 'itk::GPUAdvancedBSplineDeformableTransform::SetCoefficientImages': method with override specifier 'override' did not override any base class methods
The typo was introduced with commit 2ce0a0a "ENH: Added support for the use of OpenCL in elastix", Jan 22, 2015.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.