ENH: Replace ImpactWriteFeatureMaps with ImpactFeatureMapOutputDirectory and fix publish-elastix workflow bug#1424
Open
vboussot wants to merge 1 commit into
Open
Conversation
…) and fix publish-elastix workflow bug
vboussot
force-pushed
the
feature/impact-metric
branch
from
196ae6f to
d9cf16e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the deprecated ImpactWriteFeatureMaps parameter with ImpactFeatureMapOutputDirectory, following the suggestion by @N-Dekker (see vboussot#6).
It also fixes an issue in the publish-elastix GitHub Actions workflow related to the generation of release artifacts.
In addition, for the 5.3.1 release, GPU support could be enabled by manually running the publish-elastix.yml workflow to build the ImpactMetricCuda library, and then adding the generated binaries (ImpactMetricCuda.so for Linux and ImpactMetricCuda.dll for Windows) to the existing release archives alongside the CPU library.
At runtime, when installing the component, elastix first attempts to load ImpactMetricCuda if a compatible GPU environment is detected. Otherwise, it automatically falls back to ImpactMetric, resulting in CPU-only execution.
Currently, the 5.3.1 release only ships the CPU library, meaning that even on systems with GPU support elastix immediately falls back to ImpactMetric, and GPU acceleration cannot be used.