Add image gallery to articles #41
Conversation
# Conflicts: # ForPDA.xcodeproj/project.pbxproj
# Conflicts: # ForPDA.xcodeproj/project.pbxproj
| @@ -1,6 +1,19 @@ | |||
| { | |||
| "sourceLanguage" : "en", | |||
| "strings" : { | |||
| "" : { | |||
|
|
|||
There was a problem hiding this comment.
Пустая локализация, скорее всего надо просто завернуть вызов в String
| "" : { | ||
|
|
||
| }, | ||
| "%lld / %lld" : { |
There was a problem hiding this comment.
Либо переводим либо заворачиваем в стрингу
| @@ -20,6 +20,9 @@ struct ArticleElementView: View { | |||
| @State private var gallerySelection: Int = 0 | |||
| @State private var pollSelection: ArticlePoll.Option? | |||
| @State private var pollSelections: Set<ArticlePoll.Option> = .init() | |||
| @State private var showFullScreenImage: Bool = false | |||
| @State private var showFullScreenGallery: Bool = false | |||
There was a problem hiding this comment.
Что произойдет если мы их оба поставим на true? Мне кажется это нужно завернуть в Destination, посмотри примеры с шитами
There was a problem hiding this comment.
Оставил только showFullScreenImage
| // | ||
|
|
||
| import SwiftUI | ||
| import UIKit |
There was a problem hiding this comment.
По идее import UIKit можно убрать
|
|
||
| func updateUIView(_ uiView: UICollectionView, context: Context) { | ||
| let indexPath = IndexPath(item: selectedIndex, section: 0) | ||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
Отдаем предпочтение Task { @MainActor in
Перепроверяем что с ним все работает также
| tempFileUrls[element.offset] = tempFileUrl | ||
| } | ||
| } catch { | ||
| print("Image not loaded: \(error)") |
There was a problem hiding this comment.
нужно отобразить ошибку. (Tost manager)
| print("Image not loaded: \(error)") | ||
| } | ||
| case .failure(let error): | ||
| print("Image not loaded: \(error)") |
There was a problem hiding this comment.
нужно отобразить ошибку. (Tost manager)
| try FileManager.default.removeItem(at: fileURL) | ||
| } | ||
| } catch { | ||
| print("Error deleting temp files: \(error)") |
There was a problem hiding this comment.
нужно отобразить ошибку. (Tost manager)
| .scaleEffect(0.8) // TODO: ? | ||
| .background( | ||
| Circle() | ||
| .fill(.ultraThinMaterial.opacity(backgroundOpacity)) // Материал |
| func makeUIViewController(context: Context) -> UIActivityViewController { | ||
| let activityVC = UIActivityViewController(activityItems: activityItems, applicationActivities: nil) | ||
|
|
||
| print(activityItems) |
There was a problem hiding this comment.
Если принт больше не нужен, то убери
No description provided.