Changed the code to check for the first letter of the PR #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williamjallen I am completely new to the field of open source. Can you please guide me what necessary changes need to be done in order to make my PR accepted. The build file shows that my code failed 'npm run lint' check but when I run this command on my local host I get multiple errors. How to deal with this? |
|
The checks failed because your changes do not match our code style rules. What do you see when you run the linter locally? |
|
closing this due to lack of recent activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Submitty/Submitty#9893
The code to check if the first letter of the PR is capital has been added to the validate.ts file and the required changes in the index.js file in /dist directory have been made.